Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Requester: fix type annotation for requestBlobAndCheck #2927

Closed
wants to merge 1 commit into from

Conversation

fsouza
Copy link

@fsouza fsouza commented Mar 22, 2024

requestBlob returns tuple[int, dict[str, Any], str], so requestBlobAndCheck should return tuple[dict[str, Any], str].

requestBlob returns `tuple[int, dict[str, Any], str]`, so
requestBlobAndCheck should return `tuple[dict[str, Any], str]`.
@fsouza
Copy link
Author

fsouza commented Mar 22, 2024

oh wait I misread the code. closing

@fsouza fsouza closed this Mar 22, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.74%. Comparing base (e4106e0) to head (8836d3e).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #2927   +/-   ##
=======================================
  Coverage   96.74%   96.74%           
=======================================
  Files         147      147           
  Lines       14978    14978           
=======================================
  Hits        14491    14491           
  Misses        487      487           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fsouza fsouza deleted the fix-type-annotation branch March 22, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants