Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BaseReport Messages Include Error Row and Column Info #852

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

astro-josh
Copy link

BaseReport (used when quiet option is specified) does not include row and column numbers or other useful error info. Being able to access this info even when quiet mode is enabled may be useful for some.

UseCase: User does not want the pep8 check error printed to stdout so they enable quiet mode. User may still want to retrieve errors from BaseReport messages within a python script that checks jupyter notebook code cells for pep8 errors and generate reports for CI.

Changes:

  • Updated base report messages to a list instead of a dictionary. Stores tuples for error info.
  • Updated methods to print and get statistics fro BaseReport to work with new messages format.
  • Updated test_own_dog_food unit test to verify assertion on list of tuple instead of dictionary.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant