Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Always set encoding when reading setup.cfg #296

Merged
merged 1 commit into from Mar 13, 2024
Merged

Always set encoding when reading setup.cfg #296

merged 1 commit into from Mar 13, 2024

Commits on Mar 13, 2024

  1. Always set encoding when reading setup.cfg 

    This should fix an issue on Window where the `setup.cfg` can contain
non-ascii characters, and Python is trying to use cp1252. This should be
safe as utf-8 is compatible with cp1252.

It's possible I'll eat my words and some other platform breaks with this
change, but let's try.

Closes #294.
    @fsouza
    fsouza committed Mar 13, 2024
    Configuration menu
    Copy the full SHA
    2f53416 View commit details
    Browse the repository at this point in the history