Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow setting 'files' argument in the config file #245

Closed
wants to merge 1 commit into from

Conversation

red-hood
Copy link

@red-hood red-hood commented Apr 7, 2023

As mentioned in #239, theses changes allow passing the 'files' argument in the config file, calling autoflake without any arguments. The config file is then searched in the current working directory.

This might be useful e.g. in a CI context, where autoflake is called from a shared template with fixed arguments, but source folder layout varies between different repositories.

@red-hood
Copy link
Author

Thank you for running the tests. I decided to not continue with this effort, as usind plain unittest without the monkeypatch feature of pytest makes changing the cwd rather complicated and error prone in parallel tests.

@red-hood red-hood closed this Apr 16, 2023
@fsouza
Copy link
Collaborator

fsouza commented Apr 17, 2023

Thank you for running the tests. I decided to not continue with this effort, as usind plain unittest without the monkeypatch feature of pytest makes changing the cwd rather complicated and error prone in parallel tests.

I'd be OK with moving away from unittest, but I understand that that's also a major undertaking.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants