Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Def rework - Cardigann v8 #823

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Def rework - Cardigann v8 #823

wants to merge 4 commits into from
+417 −4,731

Conversation

Qstick
Copy link
Contributor

@Qstick Qstick commented Feb 5, 2022 •
edited by bakerboy448

Database Migration

YES - 22

Description

Switch all indexers over to base implementations and use yml to define caps, links, categories, etc.

Screenshot (if UI related)

Todos

  • Tests
  • Ymls
  • Migration for non-cardigann

Issues

@Qstick Qstick mentioned this pull request Feb 5, 2022
Closed
25 tasks
@Qstick Qstick force-pushed the def-rework branch 2 times, most recently from eb99746 to 2d7a6ae Compare February 5, 2022 21:16
@bakerboy448 bakerboy448 added Area: API Issue is related to the API Area: Cardigann labels Feb 5, 2022
@bakerboy448 bakerboy448 changed the title Def rework Def rework - Cardigann v5 Feb 5, 2022
@sonarcloud
Copy link

sonarcloud bot commented Feb 6, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

31.7% 31.7% Coverage
0.0% 0.0% Duplication

@Qstick Qstick changed the title Def rework - Cardigann v5 Def rework - Cardigann v6 Feb 28, 2022
@sonarcloud
Copy link

sonarcloud bot commented Apr 18, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

32.7% 32.7% Coverage
0.0% 0.0% Duplication

@bakerboy448 bakerboy448 added Status: Waiting for OP Action Required from OP conflict conflict - cannot merge, needs resolution Area: Indexer Issue is related to indexers. Status: Rebase Needed PR needs to be rebased on develop labels May 1, 2022
@bakerboy448

This comment was marked as off-topic.

Sign in to view
@sonarcloud
Copy link

sonarcloud bot commented Jun 6, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

29.9% 29.9% Coverage
0.0% 0.0% Duplication

@crotoc crotoc mentioned this pull request Jun 20, 2022
Closed
1 task
@Qstick Qstick changed the title Def rework - Cardigann v6 Def rework - Cardigann v7 Jun 28, 2022
@Qstick Qstick changed the title Def rework - Cardigann v7 Def rework - Cardigann v8 Jul 30, 2022
@sonarcloud
Copy link

sonarcloud bot commented Jul 31, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 9 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@bakerboy448 bakerboy448 mentioned this pull request Sep 6, 2022
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
Area: API Issue is related to the API Area: Indexer Issue is related to indexers. conflict conflict - cannot merge, needs resolution Status: Rebase Needed PR needs to be rebased on develop Status: Waiting for OP Action Required from OP
Projects
None yet
Milestone
No milestone
2 participants
@Qstick @bakerboy448