Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New: Indexer Torrent Nostr #2100

Draft
wants to merge 2 commits into
base: develop
Choose a base branch
from
Draft

New: Indexer Torrent Nostr #2100

wants to merge 2 commits into from

Conversation

v0l
Copy link

@v0l v0l commented Apr 10, 2024

Description

Implement nostr relay search for kind 2003 (Torrents) as seen on https://dtan.xyz
https://git.v0l.io/Kieran/dtan

Todos

  • Implement test method with actual query to relay asserting search support (NIP-50)
  • Pagination
  • Tests
  • Translation Keys (./src/NzbDrone.Core/Localization/Core/en.json)
  • Wiki Updates

@github-actions github-actions bot added the Area: Indexer Issue is related to indexers. label Apr 10, 2024
@mynameisbogdan mynameisbogdan added the Status: Don't Merge Hold up - don't merge this label Apr 10, 2024
@v0l
Copy link
Author

v0l commented Apr 10, 2024

@mynameisbogdan can you explain why there is 0 documentation on the base types, its impossible to know what some of these properties do

@mynameisbogdan
Copy link
Contributor

Hello, how is this supposed to work without a proxy download functionality via Prowlarr?

can you explain why there is 0 documentation on the base types, its impossible to know what some of these properties do

For example? None of the arrs use documentation comments, so it's inherited.

@v0l
Copy link
Author

v0l commented Apr 10, 2024

Hello, how is this supposed to work without a proxy download functionality via Prowlarr?

We're listing torrents on nostr so it should work the same as any of the other torrent index sites in prowler.

For example? None of the arrs use documentation comments, so it's inherited.

SupportsRss SupportsRedirect FollowRedirect Language LegacyUrls

@mynameisbogdan
Copy link
Contributor

Hello, how is this supposed to work without a proxy download functionality via Prowlarr?

We're listing torrents on nostr so it should work the same as any of the other torrent index sites in prowler.

Did you tested your implementation? I'm asking because you're overriding the Download method with a NotImplemented which makes it invalid.

Also if this is torrent based indexer, you need to use extend TorrentIndexerBase.

For example? None of the arrs use documentation comments, so it's inherited.

SupportsRss SupportsRedirect FollowRedirect Language LegacyUrls

SupportsRss = if it supports keyword-less searches.
SupportsRedirect = true allows the changing of Redirect checkbox in the UI, which affects if the torrent download is done by Prowlarr or it's proxied to the apps with a Location redirect.
FollowRedirect = if the HTTP client show follow redirects.
Language = language of the indexer
LegacyUrls = older IndexerUrls need to be added here so they can be migrated from older configs.

@v0l
Copy link
Author

v0l commented Apr 10, 2024

Did you tested your implementation? I'm asking because you're overriding the Download method with a NotImplemented which makes it invalid.

Yea this is a WIP, i just spent 1hr so far, going to finish it off tomorrow, looking for info on those props, thanks got it now.

I did some basic search tests so far with results, so everything seems fine so far

Here is the thread on nostr that started this: https://snort.social/nevent1qqs8e3rewjnpavwqejv80mm954hm9nw7kt27dhsas8pcsh24dgm9ylqppemhxue69uhkummn9ekx7mp0qgs80dgyuk8jqmp25xe2u6kvr6c3xg05qc02lj89k5cszhdu55mtfeqrqsqqqqqpps0jev

@v0l
Copy link
Author

v0l commented Apr 11, 2024

Is it possible to first query the indexer to detect and to set SupportsSearch, not all relays support the search spec?

I would need to first query the relay with HTTP get to the relay information document https://relay.nostr.band/.well-known/nostr.json

This document should include support for NIP-50

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Area: Indexer Issue is related to indexers. Status: Don't Merge Hold up - don't merge this
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants