New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New: (Cardigann) Paging Support - v9 #1479
Draft
Qstick
wants to merge
5
commits into
develop
Choose a base branch
from
paging
base: develop
Could not load branches
Branch not found: {{ refName }}
Could not load tags
Nothing to show
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example indexer change to Blu
|
@ilike2burnthing Thoughts? This expands on what you were doing with a POF to full paging support for Cardigann. b42bf2c is the relevant commit |
Looks good, and |
Qstick
changed the title
New: (Cardigann) Paging Support
New: (Cardigann) Paging Support - v9
Feb 26, 2023
Co-Authored-By: Bogdan <mynameisbogdan@users.noreply.github.com>
Co-Authored-By: Bogdan <mynameisbogdan@users.noreply.github.com>
SonarCloud Quality Gate failed. |
1 task
bakerboy448
added
Status: Waiting for OP
Action Required from OP
conflict
conflict - cannot merge, needs resolution
and removed
Status: In Progress
In Progress
labels
Mar 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Area: Indexer
Issue is related to indexers.
conflict
conflict - cannot merge, needs resolution
Status: Waiting for OP
Action Required from OP
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database Migration
NO
Description
{{ .Query.Page }}
and{{ .PageSize }}
in yml, thispage
is auto calculated based on the offset and limit passed to Prowlarr and the page size defined in the YMLThis should handle all paging scenarios
Examples
Indexer Page Size: 100 - User Search: Offset 100, Limit 100 - We should get page 2
Indexer Page Size: 100 - User Search: Offset 50, Limit 100 - We should pull page 1 and 2 and return correct items
Indexer Page Size: 100 - User Search: Offset 0, Limit 200 - We should pull page 1 and 2 and return all
Indexer Page Size: 100 - User Search: Offset 120, Limit 40 - We should get page 2 and return the correct results
Indexer Page Size 20 - User Search: Offset 40, Limit 100 - We should get and return pages 3,4,5,6,7
Todos
Fixes #379
Fixes #1470