New: freeleech token minimum torrent size #1280
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 3, 2023 12:39
Many indexers were not properly validating inherited properties, this adjusts UserPassBaseSettingsValidator and NoAuthSettingsValidator to be generic, and subclasses of the settings that need their own validators added now inherity properly from that.
I only want to use my tokens for torrents above a given size. This extends IIndexer.Download() to include optional ReleaseInfo, which can be used to compare ReleaseInfo.Size against the configured FreeleechSize. In cases like Gazelle where GetDownloadUrl() handles the `usetoken` parameter, I added a `torrentSize` parameter as well.
This comment was marked as spam.
This comment was marked as spam.
| } | ||
|
|
||
| public string AuthKey; | ||
| public string PassKey; | ||
|
|
||
| [FieldDefinition(4, Type = FieldType.Checkbox, Label = "Use Freeleech Token", HelpText = "Use freeleech tokens when available")] | ||
| public bool UseFreeleechToken { get; set; } | ||
|
|
||
| [FieldDefinition(5, Type = FieldType.Number, Label = "Freeleech Torrent Size", Unit = "bytes", Advanced = true, HelpText = "Only use freeleech tokens for torrents above a given size")] | ||
| public long FreeleechSize { get; set; } |
There was a problem hiding this comment.
Why not FreeleechTokenMinimumSize?
bakerboy448
added
Status: Waiting for OP
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Database Migration
NO
Description
I only want to use my tokens for torrents above a given size. This
extends IIndexer.Download() to include optional ReleaseInfo, which can
be used to compare ReleaseInfo.Size against the configured
FreeleechSize.
In cases like Gazelle where GetDownloadUrl() handles the
usetokenparameter, I added a
torrentSizeparameter as well.Screenshot (if UI related)
Todos
Issues Fixed or Closed by this PR
I haven't created an issue, I figured I would just PR this.
Changes to Gazelle's settings ended up based on my other PR #1279