Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add ability to skip key result tests or fix afforestation model issue #517

Open
denised opened this issue Dec 22, 2021 · 0 comments
Open

Add ability to skip key result tests or fix afforestation model issue #517

denised opened this issue Dec 22, 2021 · 0 comments
Labels
bug Something isn't working Python Model

Comments

@denised
Copy link
Member

denised commented Dec 22, 2021

Afforestation model fails key result tests because the python key result code explicitly skips certain "nonsense" situations, such as having a replacement lifetime value of 0, which Afforestation has. It might be possible to make the key results match the excel behavior, but its not certain that is worthwhile. Or, we could allow marking specific key results as accepted failures in the same way we do deep results.
@denised denised added bug Something isn't working Python Model labels Dec 22, 2021
denised added a commit that referenced this issue Dec 22, 2021
@denised
update afforestation model
ef47615 
Note afforestation still has a key result error, but the error is arguably justified.  We need to either add the ability to skip specific key results, or fix the larger issue (Issue #517)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working Python Model
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@denised