Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set global variables globally #449

Open
denised opened this issue Sep 16, 2021 · 3 comments
Open

Set global variables globally #449

denised opened this issue Sep 16, 2021 · 3 comments
Assignees
Labels
enhancement New feature or request Python Model

Comments

@denised
Copy link
Member

denised commented Sep 16, 2021

A few of the parameters (VMAs) are not specific to an individual solution: fuel cost and discount rate are two and there may be more. Scenarios each have their own individual settings for these parameters, which is fine when looking at one solution at a time. But when comparing across solutions, or doing multi-solution analysis, the value should be set consistently. We currently don't have a convenient mechanism to accomplish this.

(Observed from a presentation on electricity integration)

@denised
Copy link
Member Author

denised commented Sep 16, 2021

Assumed population model, assumed CO2 model.

@denised
Copy link
Member Author

denised commented Sep 21, 2021

For greenhouse gas model, this is actually a required part of the overall integration process. In Excel it is done by manually setting all the parameters to the right value, but in Python it makes more sense to have a set of "global parameters" which can be enforced.

@denised denised self-assigned this Sep 29, 2021
@denised
Copy link
Member Author

denised commented Sep 29, 2021

I realize that I need to have this to make elc integration work. So I'm going to start working on it now.

@eethann @sutjin I believe you have to ideas about this --- lets coordinate.
@colleenskemp FYI

My starting idea is that there will be a way to set certain AC values globally, and the effective AC used by scenarios will be the merge of the global with their own (global wins).

Historical testing can continue to use the "as saved" values, but in most contexts, at least some variables (fuel cost, discount rate, which CC model to use, ...) will be set globally. The base code in solutions doesn't have to limit which values are considered global---we should probably start with a standard set(?), but it should be possible to add or remove (set or unset) variables from the global values dynamically without requiring code changes.

@denised denised removed the good first issue Good for newcomers label Oct 3, 2021
@denised denised added the enhancement New feature or request label Aug 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request Python Model
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant