Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug fixes #119

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Bug fixes #119

wants to merge 4 commits into from

Conversation

seanjhardy
Copy link
Contributor

@seanjhardy seanjhardy commented Nov 26, 2022 •
edited

Please describe the changes this PR makes and why it should be merged, as well as any and all proof of successful tests:

Semantic versioning classification:

  • This PR changes the framework's interface (methods or parameters added)
    • This PR includes breaking changes (methods removed or renamed, parameters moved or removed)
  • This PR only includes non-code changes, like changes to README, etc.

OmerSabic
OmerSabic previously approved these changes Nov 27, 2022
View reviewed changes
Copy link
Contributor

@OmerSabic OmerSabic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I trust Sean tested it

OmerSabic
OmerSabic approved these changes Nov 27, 2022
View reviewed changes
Copy link
Contributor

@OmerSabic OmerSabic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's better this time, I promise

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@OmerSabic OmerSabic OmerSabic approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@seanjhardy @OmerSabic