Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added definition for FleetDM fleetd #670

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

jc0b
Copy link

@jc0b jc0b commented May 1, 2024

This adds a profile manifest for FleetDM's fleetd agent, for use with their Config-less fleetd agent deployment.

@relgit relgit added the 📝 new manifest New manifest request label May 1, 2024
Copy link
Collaborator

@kevinmcox kevinmcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the contribution!

I left a couple inline comments.

@jc0b
Copy link
Author

jc0b commented May 2, 2024

I assume this will be merged at some point? I don't have merge permissions myself, so just checking 😅

@kevinmcox
Copy link
Collaborator

Yep, I just need one of the other two maintainers to also review it first.

@jc0b
Copy link
Author

jc0b commented May 2, 2024

Hmm, we might want to put merging this on-hold actually. The method their agent uses to get it's own configuration would require omitting the UUID in PayloadIdentifier, which (as far as I can tell) is not possible. It seems they look for an exact match on that key, which generated profiles would not provide. I'll raise this with them also

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📝 new manifest New manifest request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants