Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update com.barebones.bbedit.plist #659

Merged
merged 3 commits into from May 21, 2024
Merged

Conversation

RedClawx
Copy link
Contributor

@RedClawx RedClawx commented Mar 7, 2024

Added all available preferences into the manifest for BBEdit 15.0.1, including all the Expert preference settings.

@kevinmcox kevinmcox added the 🛠️ update manifest Update existing manifest label Mar 7, 2024
Copy link
Collaborator

@relgit relgit left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an incredible amount of work, thank you @RedClawx.

I can see some iMazing-only PFM tags, so I'm assuming it must have been tested on iMazing Profile Editor. Were you able to test on ProfileCreator?

I found one property that has been completely removed, AlwaysUseSystemAppearanceForTitleBar. We prefer keeping deprecated and removed properties and marking them accordingly (pfm_app_deprecated and pfm_app_max).

Could you please restore that property and others that may have been removed?

@RedClawx
Copy link
Contributor Author

Good day,
I was testing specifically with iMazing Profile Editor. I did not do any testing with ProfileCreator.

For the removed keys: The reason I removed tham was due to them no longer being available from BBEdit 12.6.7 or better. version 12.6.7 was as far back as I could go. I'm not able to run anything earlier. The OS I was running for compiling all the keys was macOS 13. Any keys I wasn't able to locate were removed as I don't really know when those kays had been removed from BBEdit. The only versions of BBEdit I gathered keys from were from 12.6.7 through 15.0.1.

I can resotre the keys from the original entries, but I wouldn't know at what point they were deprecated and removed.

@RedClawx
Copy link
Contributor Author

The follow keys have been removed or replaced. If you still want me to add the keys back in, is it okay to add them under to a seperate tab called "Removed"?

  1. Old Key
    • Replaced by
  2. AlwaysUseSystemAppearanceForTitleBar
    • ApplicationAppearanceMode
  3. GitToolPathOverride
  4. MoveModelessWindowsToActiveSpace
    • MoveModelessWindowToActiveSpace
  5. MoveModelessWindowsToActiveSpace_FindWindow
  6. MoveModelessWindowsToActiveSpace_MultiFileFindWindow
  7. MoveModelessWindowsToActiveSpace_OpenFileByNameWindow
  8. NSRecentDocumentsLimit:Folders
    • NSRecentDocumentsLimit_Folders
  9. NSRecentDocumentsLimit:Images
    • NSRecentDocumentsLimit_Images
  10. NSRecentDocumentsLimit:Projects
    • NSRecentDocumentsLimit_Projects
  11. QuickTimeImages
  12. ReopenRemoteDocuments
    • ReopenDocumentsOnRemoteVolumes
  13. SUAllowsAutomaticUpdates
    • SUSoftwareUpdateEnabled
  14. SUAutomaticallyUpdate
    • SUSoftwareUpdateEnabled
  15. SubversionToolPathOverride
  16. SUEnableAutomaticChecks
    • SUSoftwareUpdateEnabled
  17. SUFeedURL
  18. SUScheduledCheckInterval
  19. UseSystemAppearanceWhenInDarkMode
    • ApplicationAppearanceMode

@relgit
Copy link
Collaborator

relgit commented Mar 27, 2024

Thanks for detailing your method.

Several keys have indeed been removed but I'd like to keep them. Others were simply never documented and should also remain.

Here's a breakdown of which ones should remain and why:

All keys beginning with MoveModelessWindowsToActiveSpace were removed recently from the expert preference page, so let's keep and tag as deprecated in 15.0. Also, I can't find the replacement you mentioned (MoveModelessWindowToActiveSpace) in the updated manifest.

QuickTimeImages was removed from version 15.0 so let's keep and tag accordingly.

ReopenRemoteDocuments same as above.

All the keys beginning with SU belong to the Sparkle update library. Those are usually undocumented but should definitely remain. Also, were did you find the replacement key SUSoftwareUpdateEnabled? Looking at the user manual doesn't reveal the actual key name.

I also can't find the new ApplicationAppearanceMode in the documentation - how did you arrive at the key's name?

That's it. The rest can stay removed. After you restore the above and clarify the method for arriving at the new key names we'd be able to merge the work. Thanks!

@RedClawx
Copy link
Contributor Author

RedClawx commented Apr 1, 2024

I made the changed requested. I added 2 tabs for them. The first tab is for the Removed Expert keys that are no longer in version 15. The second tab is for the "SU" keys.

MoveModelessWindowToActiveSpace was also added in. I must have skiped over that key when building the new manifest.

SUSoftwareUpdateEnabled and ApplicationAppearanceMode, as with all the other keys I collected, was found by comparing the preference file for BBEdit after making a change to the preferences. I copied the BBedit pref once to get the default settings. Then I launched BBEdit, made a change to its settings. Then used BBEdit on another computer to compare the changed preference file with the unchanged preference file. It was a pain in the rear to do, but it did get me the actual key names for almost every setting.

@relgit
Copy link
Collaborator

relgit commented May 17, 2024

@RedClawx thanks for the clarification, and thanks for making the changes.

I made a few extra ones, mainly for compatibility with the repository, which you can see here:
https://github.com/ProfileCreator/ProfileManifests/commits/redclawx-master/

If those are all Ok with you, I'm ready to merge both your commits and mine.

@RedClawx
Copy link
Contributor Author

Those look fine. Go ahead and merge.

@relgit relgit merged commit ae507e6 into ProfileCreator:master May 21, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ update manifest Update existing manifest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants