Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance 1Password 8 manifest with iOS keys #598

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

fspeirs
Copy link

@fspeirs fspeirs commented Feb 1, 2023

Sorry about the earlier botched PR. This one should be more easily mergeable - it adds information about the keys supported by iOS and clarifies some of the text.

Is it OK to have an overall pfm_app_min at the top of the file, rather than having them in each item, given that all of these keys are supported on 8.9 and later on both platforms?

Also, I couldn't figure out how to have a different pfm_range_min value for different platforms for the key security.autolock.minutes. It should be 1 on macOS and 0 on iOS. I'm happy to adapt this PR if you can advise.

@kevinmcox kevinmcox added the 🛠️ update manifest Update existing manifest label Feb 1, 2023
@apizz
Copy link
Collaborator

apizz commented Feb 20, 2023

@fspeirs The idea is that the top-level pfm_app_min version in the manifest should reflect "high-level" minimum app version that supported management. As new preferences are added or are supported on different platforms, that's when you'd use the pfm_app_min at the preference level to indicate what's supported. That said, gaining iOS support for a set of preferences with pfm_app_min isn't possible on a per-OS basis, so I think the following is best:

  1. Leave top-level pfm_app_min at 8.0.
  2. For any existing preferences that were supported on macOS that are now also supported on iOS, leave the current pfm_app_min specified in the preference and add a pfm_note indicating what app version (8.9?) gained iOS support.
  3. For new prefs that are only supported on iOS, add pfm_app_min at 8.9 for each of those preferences.

@apizz apizz self-assigned this Feb 20, 2023
Copy link
Collaborator

@apizz apizz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Per prev. comment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🛠️ update manifest Update existing manifest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants