Enhance 1Password 8 manifest with iOS keys #598
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry about the earlier botched PR. This one should be more easily mergeable - it adds information about the keys supported by iOS and clarifies some of the text.
Is it OK to have an overall
pfm_app_min
at the top of the file, rather than having them in each item, given that all of these keys are supported on 8.9 and later on both platforms?Also, I couldn't figure out how to have a different
pfm_range_min
value for different platforms for the keysecurity.autolock.minutes
. It should be 1 on macOS and 0 on iOS. I'm happy to adapt this PR if you can advise.