Make Location Procedures Testable in client code #865
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 3 commits
July 4, 2018 11:38
…or testability These changes enable framework clients to test code / procedures that are dependant upon location procedures without relying on an actual CLLocationManager instance.
|
Hi @ericyanush will look at this asap. Thanks for the contribution! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR exposes the ability for client code to inject mock LocationFetcher (CLLocationManager), and ReverseGeocoder (CLGeocoder) into location procedures.
This is necessary to allow any client code that depends on or uses, especially in GroupProcedures, a procedure from ProcedureKitLocation. Without these changes, client code is subject to the state of the device/simulator during unit tests, making it impossible to validate behaviour when location services is disabled, no location is available, etc.