Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

better usability for deletelink #268

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

ukcb
Copy link

@ukcb ukcb commented Dec 27, 2017

only a small change

Edit by @rugk: Fixes #266

Copy link
Member

@rugk rugk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ukcb,
thanks for your first contribution to this project! 🎉 👍
I hope you'll like this project and can enjoy hacking on it… 😃
So with your change the delete link is very bright and yellow now…

deletelink

I like that it is more obvious/visible now, but maybe it is a bit too much in this yellow/red thing, which does not really fit into the overall design.

Maybe better try to use a button design Bootstrap already provides: https://v4-alpha.getbootstrap.com/components/buttons/
Then you may also not need much CSS, but just add some classes from Bootstrap to the template or so.
Keep in mind to not make the button to bright. We do not want to encourage users to accidentally click on it or so.

Also, BTW, as per our editorconfig please intend CSS files with tabs instead of spaces.

@elrido
Copy link
Contributor

elrido commented Jan 2, 2018

Good idea, @rugk. How about adding one of the following, existing classes to the link:

class="btn btn-primary btn-sm" or class="btn btn-outline-primary btn-sm"?

@rugk
Copy link
Member

rugk commented Jan 2, 2018

Yeah, why not? @ukcb so could you try that out?

@ukcb
Copy link
Author

ukcb commented Jan 3, 2018

I tested with class="btn btn-primary btn-sm"

1

and with class="btn btn-outline-primary btn-sm"

2

It is not that beautiful, and I do not have the left distance.

@rugk
Copy link
Member

rugk commented Jan 3, 2018

Yeah you can manually add a margin though and change the text-color so it is readable.

@elrido elrido added this to the Release 1.4 - improved UI milestone Aug 11, 2018
@elrido elrido moved this from To do to In progress in Release 1.4 - improved UI Jul 9, 2019
@rugk
Copy link
Member

rugk commented Aug 7, 2023

@ukcb Are you still interested in it? If not, that's no problem, just add a notice, so I know what the current status of this issue is.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

Stylesheet at #deletelink
3 participants