Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Stylesheet at #deletelink #266

Open
ukcb opened this issue Dec 25, 2017 · 7 comments · May be fixed by #268
Open

Stylesheet at #deletelink #266

ukcb opened this issue Dec 25, 2017 · 7 comments · May be fixed by #268
Labels
enhancement help wanted UI/UX

Comments

@ukcb
Copy link

ukcb commented Dec 25, 2017

Please make a small change in the stylesheet for better usability:

#deletelink {
    float: right;
    background-color: #ffa;
    border: 3px solid #f00;
    margin-left: 10em;
    padding: .3em;
}

Or something like that, the main thing you see the delete link better.
Many Thanks.
@rugk
Copy link
Member

rugk commented Dec 25, 2017

Thanks for your suggestion. You can send us a PR for that. Just edit PrivateBin's bootstrap CSS file.

@ukcb
Copy link
Author

ukcb commented Dec 26, 2017

Sorry, I did not want to get that deep in github. I'm not a developer, sometimes I just want to make a message to the developers. Would be nice if you could commit it. It's just a suggestion, the developers should decide.

@rugk
Copy link
Member

rugk commented Dec 26, 2017

You do not need to get deep into that at all, and you can easily edit the file online at GitHub e.g. So it is really easy and fast to do! 😃

If you also change it in your browser, you can make a screenshot and then we can look whether we like the change, you propose.

@ukcb
Copy link
Author

ukcb commented Dec 26, 2017

Ok, I'll try it.

@ukcb
Copy link
Author

ukcb commented Dec 27, 2017

I tried, hopefully I did not do anything wrong. :-)

@rugk
Copy link
Member

rugk commented Dec 31, 2017 •
edited

No, you did not do anything wrong with the PR. It works all right. We are just reviewing it, and may request some changes and so on. You can just commit & push these changes to the same branch as you used for the PR and they appear on GitHub automatically.

@ukcb ukcb linked a pull request Dec 31, 2017 that will close this issue
Open
@ukcb
Copy link
Author

ukcb commented Jan 1, 2018

I do not really care about the colors. I am concerned with the delimitation of the other text, therefore the right distance. The problem should be clear in the screenshot. I do not think the colors are that bad. :-)

fertig

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement help wanted UI/UX
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

better usability for deletelink ukcb/PrivateBin
3 participants
@elrido @rugk @ukcb