Add new cached block loops and builder #139
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add saveAndQuit() method
extremeheat
commented
Jan 17, 2024
| @@ -27,6 +28,11 @@ class World extends EventEmitter { | |||
| if (storageProvider && savingInterval !== 0) this.startSaving() | |||
| } | |||
|
|
|||
| setRegistry (registry) { | |||
There was a problem hiding this comment.
This is a bit weird, since prismarine-world needs an instance of prismarine-registry in order to build the block cache (so setRegistry() needs to be called before buildBlockCache()). There is a loader function in prismarine-world, but because of the async/sync setup inside prismarine-world, it's not possible to wrap the class inside the loader function.
A breaking refactor might be needed to fix the async/sync situation
|
Removed dependencies detected. Learn more about Socket for GitHub ↗︎ 🚮 Removed packages: buffer-equal@1.0.1 |
|
See #64 regarding sync/async |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds cached block lookup API like done in prismarine-viewer for performance (to avoid object creation).
Adds a
.getCachedBlock(pos)replacement for.getBlock(pos), and a.buildBlockCache()function that has to be called to build the block cache (ideally after prismarine-world instantiation).Also add a saveAndQuit() method to save and close timers to not hang tests.