Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

1.17.1 support #650

Draft
wants to merge 10 commits into
base: master
Choose a base branch
from
Draft

1.17.1 support #650

wants to merge 10 commits into from

Conversation

Pandapip1
Copy link
Contributor

@Pandapip1 Pandapip1 commented Jan 8, 2024 •
edited

@Pandapip1 Pandapip1 mentioned this pull request Jan 8, 2024
Open
@rom1504
Copy link
Member

rom1504 commented Jan 12, 2024

Looks like tests are passing.

Do things seem to work?

@rom1504 rom1504 marked this pull request as ready for review January 12, 2024 20:29
rom1504
rom1504 reviewed Jan 12, 2024
View reviewed changes
src/lib/plugins/world.js
}
}, // FIXME: fake heightmap
chunkData: chunk.dump(),
blockEntities: []
})
if (registry.supportFeature('lightSentSeparately')) {
if (registry.supportFeature('dimensionDataIsAvailable')) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the feature seems unrelated with the content of this if

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copied directly from mineflayer code.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://github.com/PrismarineJS/mineflayer/blob/5c71edf48bb2f2dfa16cddb9af5baa0c4d55cf0d/lib/plugins/blocks.js#L264 definitely has the same issue

@Pandapip1
Copy link
Contributor Author

Pandapip1 commented Jan 12, 2024 •
edited

Looks like tests are passing.

Do things seem to work?

THINGS DO NOT WORK. Particularly, world saving is completely borked and sometimes the server crashes when trying to send chunk packets (all to do with the palette set to null error).

@Pandapip1 Pandapip1 marked this pull request as draft January 12, 2024 22:03
@rom1504 rom1504 added this to Needs triage in PR Triage Jan 14, 2024
@rom1504 rom1504 moved this from Needs triage to Waiting for user input in PR Triage Jan 14, 2024
@rom1504
Copy link
Member

rom1504 commented Jan 14, 2024

I made PrismarineJS/prismarine-provider-anvil#74 which I think should fix this anvil problem

Can you check if that helps the error you were seeing @Pandapip1 ?

@socket-security Socket Security
Copy link

socket-security bot commented Jan 14, 2024 •
edited

Removed dependencies detected. Learn more about Socket for GitHub ↗︎

🚮 Removed packages: npm/prismarine-provider-anvil@2.7.0

View full report↗︎

@rom1504 rom1504 moved this from Waiting for user input to Important to finish in PR Triage Jan 14, 2024
@Pandapip1
Copy link
Contributor Author

I'm still getting the following error, even after updating:

January 14th 2024, 16:30:13 [ERROR]: -------------------------------
January 14th 2024, 16:30:13 [ERROR]: Please report this flying-squid! This is bug (mabye)
January 14th 2024, 16:30:13 [ERROR]: Something went wrong!
January 14th 2024, 16:30:13 [ERROR]: Error: TypeError: this.sectionMask.toLongArray is not a function
    at ChunkColumn.getMask (/home/gavin/repos/flying-squid/node_modules/prismarine-chunk/src/pc/1.17/ChunkColumn.js:244:31)
    at /home/gavin/repos/flying-squid/src/lib/plugins/world.js:188:23
    at Entity.behavior (/home/gavin/repos/flying-squid/src/lib/behavior.js:24:14)
    at process.processTicksAndRejections (node:internal/process/task_queues:95:5)
    at async player.login (/home/gavin/repos/flying-squid/src/lib/plugins/login.js:222:5)
    at async Server.<anonymous> (/home/gavin/repos/flying-squid/src/lib/plugins/login.js:29:7)
January 14th 2024, 16:30:13 [ERROR]: Report this error here: https://github.com/PrismarineJS/flying-squid/issues
January 14th 2024, 16:30:13 [ERROR]: -------------------------------
January 14th 2024, 16:30:13 Server shutting down...

@rom1504
Copy link
Member

rom1504 commented Jan 14, 2024

ok that's a different error than the palette

@rom1504
Copy link
Member

rom1504 commented Jan 14, 2024

would be great to have a test showing this, would make it faster to debug

@rom1504
Copy link
Member

rom1504 commented Feb 26, 2024

PrismarineJS/prismarine-provider-anvil#75 / PrismarineJS/prismarine-provider-anvil#73 is the blocker here

@rom1504 rom1504 mentioned this pull request Mar 29, 2024
Open
@privt00
Copy link
Contributor

privt00 commented Mar 29, 2024 •
edited

hey
i think i made progress

getting now this error

March 29th 2024, 18:47:08 [ERROR]: Error: TypeError: this.skyLightMask.toLongArray is not a function
at ChunkColumn.dumpLight (C:\Users\Noah\Documents\mclient\node_modules\prismarine-chunk\src\pc\1.17\ChunkColumn.js:379:61)
at C:\Users\Noah\Documents\mclient\src\lib\plugins\world.js:245:20
at Entity.behavior (C:\Users\Noah\Documents\mclient\fly-high\src\lib\behavior.js:24:14)
at process.processTicksAndRejections (node:internal/process/task_queues:95:5)

after world safe in 1.17.1 but yeah im tryng to fix it at moment i just dont know if its has somthing to do whit the anvil or just whit the chunkColumn.js

@privt00
Copy link
Contributor

privt00 commented Mar 29, 2024

i also try fixing redstone like piston activated and all stuff

@privt00
Copy link
Contributor

privt00 commented Mar 29, 2024

i fixed this error

@privt00
Copy link
Contributor

privt00 commented Mar 29, 2024

just need to fix the lightnigs

@privt00
Copy link
Contributor

privt00 commented Mar 29, 2024

ok made now the 1.17.1 support

@privt00
Copy link
Contributor

privt00 commented Mar 29, 2024

oh no relised world dosnt safe you just can join and build but nothing gets saved

@privt00
Copy link
Contributor

privt00 commented Mar 29, 2024

@rom1504 in which file is the savin logik?

@rom1504
Copy link
Member

rom1504 commented Mar 29, 2024

This repo PrismarineJS/prismarine-provider-anvil#73

@Pandapip1 Pandapip1 mentioned this pull request Apr 22, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rom1504 rom1504 rom1504 left review comments

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
PR Triage
  
Important to finish
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Pandapip1 @rom1504 @privt00