ISA-based refactor to move OST1 into a submodule #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactoring ISA tests by ISA - Moving sparcv9 tests into sparcv9-ost1-tests submodule - Cleaning up headers, moving OST1 headers into sparc/include/ - Moving TRI transducers into sparc/ and pico/ - Moving FPU, common files into sparc/ - Adding hierarchy layer sparc_tri to simplify tile
Jbalkind
force-pushed
the
isa-reorg-rebase
branch
from
bc57dfd
to
6a1a83d
Compare
Jbalkind
force-pushed
the
isa-reorg-rebase
branch
from
6a1a83d
to
f00ed67
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a large-looking refactor that actually doesn't affect that many places in the repo. I moved the OST1 core into a submodule and the SPARCv9 tests into a submodule, so there are a large amount of deletions (new record! 11.5M lines of deletions). This moves the tests around so they're separated by ISA under piton/verif/diag/ and there are a bunch of headers that got cleaned up with some headers and modules moved under piton/design/chip/tile/sparc
This also requires -ost1 to be passed to sims if using the OST1 core. This fixes an issue with sims regressions where it was including -ost1 even when -ariane or -pico were set but it also changes the expected API to sims. I still need to change the README accordingly to make this clear to users
Also the submodules are currently set to not update. However, it requires some weird incantation to git to actually make it instantiate the submodule. I might undo that part. Overall this PR should make shallow repo clones really fast because a huge amount of code has been moved out of the repo
Little more detail:
This will require some verification to be sure I didn't break anything before we merge