Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HTML: adjust spacing of icons in footer #2075

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

whaynes
Copy link
Contributor

@whaynes whaynes commented Sep 23, 2023

This pull request removes the width attribute on the PreTeXt logo in the page footer.

This width is preventing the footer's flexbox from distributing the PreTeXt, Runestone, and MathJax icons evenly.

@davidfarmer
Copy link
Contributor

I am not seeing how this makes a difference in the footer,
nor that it is not evenly spaced already:

https://pretextbook.org/examples/sample-article/html/derivatives.html

@whaynes
Copy link
Contributor Author

whaynes commented Sep 23, 2023 via email

@whaynes
Copy link
Contributor Author

whaynes commented Sep 24, 2023

This is what I see with and without the width="100%".
footers

This is what I see on my iPhone
IMG_7919

@rbeezer
Copy link
Collaborator

rbeezer commented Apr 20, 2024

Where are we on this one? Spacing looks fine to me in Firefox and in Chrome, both wide ans mobile-skinny. Maybe we can ask for some Safari-testing on the -dev list to see if that is the real culprit.

I'm hesitant to think that editing the one SVG image directly is the solution here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants