fix(youtube): channel name and viewed content #8362
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DarkVillager
suggested changes
May 9, 2024
Co-authored-by: Dark_Ville <42322979+DarkVillager@users.noreply.github.com> Signed-off-by: Daniel Lau <32113157+theusaf@users.noreply.github.com>
theusaf
approved these changes
May 11, 2024
Bas950
approved these changes
May 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Came across instance where channel name and selected tabs were not showing up in Presence (
undefinedandnullrespectively)Line 330: Adjusted an
ifstatement that was causing channel name to be reported asnullwhen an element on page was not found (String.includes('')is always true)Line 349: Changed querystring to properly find selected tab of viewed content (Featured, Videos, ...) as it was returning
undefinedAcknowledgements
yarn formatScreenshots
Proof showing the creation/modification is working as expected