Passing proxy info along when registering default repository #573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm not sure if this was just an oversight or if it was intentionally left out, but if I specify -Proxy and/or -ProxyCredentials when calling Register-PSRepository -Default, they get ignored because they don't get passed along here. In PowerShell 6 this makes it impossible to register PS Gallery behind a proxy, since you can't set the default proxy on HttpClient.
I'm not super familiar with PowerShell testing, but it didn't look like we were doing mock/expect type testing, and setting a proxy value for real would always fail unless there was in fact a proxy running. If there is a place/approach I should use to test this, let me know and I'll try to get it added.