Rename private methods in MshCommandRuntime.cs

[vexx32]

PR Summary

Renamed methods to avoid confusion when examining and maintaining core runtime code.

• DoWriteObjects() -> DoWriteEnumeratedObject()
  • This was almost identical in name to the distinct DoWriteObject() (no s) method.
• _WriteObjectsSkipAllowCheck() -> _EnumerateAndWriteObjectSkipAllowCheck()
  • Again, almost identical in name to _WriteObjectSkipAllowCheck()

This pair of methods is not actually referenced outside MshCommandRuntime.cs, and only in one or two places; I consider renaming it to be of no risk whatsoever as it is a private method.

There are no functional modifications, just renaming these before someone digs a little too deep here and breaks it by accident due to the very confusing naming scheme.

PR Context

As I was debugging #5955 I noticed that there are two pairs of commands in MshCommandRuntime.cs that deal with writing objects, one set which permits enumerating collections, the other which does not.

These are named far too similarly, where a mere typo could cause the wrong one to be used if this code is ever updated.

PR Checklist

• PR has a meaningful title
  • Use the present tense and imperative mood when describing your changes
• Summarized changes
• Change is not breaking
• Make sure all .h, .cpp, .cs, .ps1 and .psm1 files have the correct copyright header
• This PR is ready to merge and is not Work in Progress.
  • If the PR is work in progress, please add the prefix WIP: or [ WIP ] to the beginning of the title (the WIP bot will keep its status check at Pending while the prefix is present) and remove the prefix when the PR is ready.
• User-facing changes
  • Not Applicable
  • OR
  • Documentation needed
    • Issue filed:
• Testing - New and feature
  • N/A or can only be tested interactively
  • OR
  • Make sure you've added a new test if existing tests do not effectively test the code changed
    • Add [feature] to your commit messages if the change is significant or affects feature tests

[iSazonov]

Suggested change

	internal void _EnumerateAndWriteObjectSkipAllowCheck(object sendToPipeline)
	internal void EnumerateAndWriteObjectSkipAllowCheck(object sendToPipeline)

[vexx32]

If I go that route it might be better to just rename half the things in this file, in all honesty... There are a lot of similarly questionable names here.

[iSazonov]

Oh, no. It is better to spend time to create something useful.

[vexx32]

I'll come back to it when I'm really bored and do a proper style pass over the whole thing. 😉

Not a big-ticket item, but there's a lot of room for tidying up in this one. 😄