Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for named argument with .NET Methods #21487

Open
wants to merge 23 commits into
base: master
Choose a base branch
from
Open

Add support for named argument with .NET Methods #21487

wants to merge 23 commits into from

Commits on Jun 11, 2024

  1. Add parsing work for named arguments

    @jborean93
    jborean93 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    871e7ae View commit details
    Browse the repository at this point in the history

  2. Expand tests and fix up remaining token parser

    @jborean93
    jborean93 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    da97427 View commit details
    Browse the repository at this point in the history

  3. Pass through argument names through CallInfo

    @jborean93
    jborean93 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    9544976 View commit details
    Browse the repository at this point in the history

  4. Pass down argument names to best method specifier

    @jborean93
    jborean93 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    428bb14 View commit details
    Browse the repository at this point in the history

  5. Add check for duplicate labels in parsing

    @jborean93
    jborean93 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    6506c85 View commit details
    Browse the repository at this point in the history

  6. Add check to ensure named arguments always appear after other named a… 

    …rguments
    @jborean93
    jborean93 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    20d5b31 View commit details
    Browse the repository at this point in the history

  7. Add name logic for overload candidate selection

    @jborean93
    jborean93 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    9a0e8b7 View commit details
    Browse the repository at this point in the history

  8. Remap args after finding best overload

    @jborean93
    jborean93 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    d06ac7d View commit details
    Browse the repository at this point in the history

  9. Add test cases

    @jborean93
    jborean93 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    ad78259 View commit details
    Browse the repository at this point in the history

  10. Slowly fix params examples - support params and default MI

    @jborean93
    jborean93 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    e60730b View commit details
    Browse the repository at this point in the history

  11. Use new OverloadArgument setup

    @jborean93
    jborean93 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    8cd9681 View commit details
    Browse the repository at this point in the history

  12. Use new OverloadCandidate rules

    @jborean93
    jborean93 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    29afdd5 View commit details
    Browse the repository at this point in the history

  13. Cover more edge cases and expand docs

    @jborean93
    jborean93 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    aac6682 View commit details
    Browse the repository at this point in the history

  14. Cleanup before PR

    @jborean93
    jborean93 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    388d1f7 View commit details
    Browse the repository at this point in the history

  15. Fix build for Windows

    @jborean93
    jborean93 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    d415082 View commit details
    Browse the repository at this point in the history

  16. Fix index check for CallInfo that is not set

    @jborean93
    jborean93 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    3cdaaf3 View commit details
    Browse the repository at this point in the history

  17. Fix support for null argument names

    @jborean93
    jborean93 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    47eaea6 View commit details
    Browse the repository at this point in the history

  18. Avoid test class name collision

    @jborean93
    jborean93 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    a414d35 View commit details
    Browse the repository at this point in the history

  19. Fix up CallInfo ArgumentName logic

    @jborean93
    jborean93 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    ac4a71d View commit details
    Browse the repository at this point in the history

  20. Add tests for COM

    @jborean93
    jborean93 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    b12920f View commit details
    Browse the repository at this point in the history

  21. Make .NET args case insensitive and fix collision fallback

    @jborean93
    jborean93 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    6bfc535 View commit details
    Browse the repository at this point in the history

  22. Re-add DebuggerDisplay

    @jborean93
    jborean93 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    8ed0014 View commit details
    Browse the repository at this point in the history

  23. Remove stray WriteLine and rename Ast to NamedMethodArgumentAst

    @jborean93
    jborean93 committed Jun 11, 2024
    Configuration menu
    Copy the full SHA
    4a6fc97 View commit details
    Browse the repository at this point in the history