Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Native invocation using ArgumentList #14692

Merged
merged 22 commits into from Apr 1, 2021

Commits on Mar 23, 2021

  1. Support using ArgumentList with native app execution

    Support both behaviors with PowerShell variable
    JamesWTruher committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    f9cd8c5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8dc0d52 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    7e74f9e View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    581b91a View commit details
    Browse the repository at this point in the history
  5. Add passing native args as argumentlist as an experimental feature.

    Refactor adding variables to initial session state so experimental feature variables
    can be easily omitted based on whether the experimental feature is enabled
    JamesWTruher committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    ef03db7 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    c676e1d View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    7485621 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    4d2b442 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    fadf451 View commit details
    Browse the repository at this point in the history
  10. Refactor argument list creation to use common method.

    This is because we need to pass the parameter to handle the case in a native app where '-parm:value' is presented.
    JamesWTruher committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    93b4c4b View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    15f2851 View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    37ada29 View commit details
    Browse the repository at this point in the history
  13. Fix test by removing (now) extraneous extra quotes

    Fix additional codefactor issues
    JamesWTruher committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    310c731 View commit details
    Browse the repository at this point in the history
  14. fix codefactor issue

    JamesWTruher committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    8ebabbe View commit details
    Browse the repository at this point in the history
  15. Suppress warning about using global variables

    In this case, we want to be sure that the global variable for the new native argument handler provides the correct message when assigning an invalid value
    JamesWTruher committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    0331d3d View commit details
    Browse the repository at this point in the history
  16. Address some PR feedback

    Add a test to handle embedded single quotes.
    Remove duplicate experimental feature.
    JamesWTruher committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    4ae012d View commit details
    Browse the repository at this point in the history
  17. Address some concerns in PR review

    Added test for empty string command.
    Protected the call to the pager behind a Get-ExperimentalFeature call so the old path is taken.
    Made the experimental feature a const to follow guidance.
    JamesWTruher committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    ab67f99 View commit details
    Browse the repository at this point in the history
  18. Configuration menu
    Copy the full SHA
    ee1f5f5 View commit details
    Browse the repository at this point in the history
  19. Fix typo in test.

    Optimize help function to not invoke Get-ExperimentalFeature.
    Add additional test for variation in Windows parameter style.
    JamesWTruher committed Mar 23, 2021
    Configuration menu
    Copy the full SHA
    7ee22e2 View commit details
    Browse the repository at this point in the history

Commits on Mar 24, 2021

  1. Configuration menu
    Copy the full SHA
    4eae549 View commit details
    Browse the repository at this point in the history

Commits on Mar 31, 2021

  1. Update src/System.Management.Automation/engine/NativeCommandParameter…

    …Binder.cs
    
    Co-authored-by: Ilya <darpa@yandex.ru>
    JamesWTruher and iSazonov committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    6564558 View commit details
    Browse the repository at this point in the history
  2. Update src/System.Management.Automation/engine/NativeCommandParameter…

    …Binder.cs
    
    Co-authored-by: Ilya <darpa@yandex.ru>
    JamesWTruher and iSazonov committed Mar 31, 2021
    Configuration menu
    Copy the full SHA
    8245690 View commit details
    Browse the repository at this point in the history