address Ilya's feedback

PowerShell · Aug 12, 2020 · 957f516 · 957f516
1 parent f651490
commit 957f516
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 18 deletions.
diff --git a/src/Microsoft.PowerShell.ConsoleHost/host/msh/CommandLineParameterParser.cs b/src/Microsoft.PowerShell.ConsoleHost/host/msh/CommandLineParameterParser.cs
@@ -885,7 +885,7 @@ private void ParseHelper(string[] args)
                     ++i;
                     if (i >= args.Length)
                     {
-                        WriteCommandLineError(
+                        SetCommandLineError(
                             CommandLineParameterParserStrings.MissingOutputLogParameter);
                         break;
                     }
@@ -995,21 +995,6 @@ private void ParseHelper(string[] args)
                 }
             }
 
-            if (_showHelp)
-            {
-                ShowHelp();
-            }
-
-            if (_showBanner && !_showHelp)
-            {
-                DisplayBanner();
-
-                if (UpdatesNotification.CanNotifyUpdates)
-                {
-                    UpdatesNotification.ShowUpdateNotification(_hostUI);
-                }
-            }
-
             if (string.Equals(AppDomain.CurrentDomain.FriendlyName, ConsoleHost.PwshwHost, StringComparison.OrdinalIgnoreCase))
             {
                 _noInteractive = true;
@@ -1371,7 +1356,7 @@ private bool CollectArgs(string[] args, ref int i)
         private bool _wasCommandEncoded;
         private uint _exitCode = ConsoleHost.ExitCodeSuccess;
         private bool _dirty;
-        private string _outputLog;
+        private string _outputLog = String.Empty;
         private Serialization.DataFormat _outFormat = Serialization.DataFormat.Text;
         private bool _outputFormatSpecified = false;
         private Serialization.DataFormat _inFormat = Serialization.DataFormat.Text;

diff --git a/src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHostUserInterface.cs b/src/Microsoft.PowerShell.ConsoleHost/host/msh/ConsoleHostUserInterface.cs
@@ -576,7 +576,7 @@ private void WriteToConsole(ReadOnlySpan<char> value, bool transcribeResult, boo
                     ConsoleControl.ConsoleModes.ProcessedOutput
                     | ConsoleControl.ConsoleModes.WrapEndOfLine;
 
-                if ((m & DesiredMode) != DesiredMode)
+                if (!m.HasFlag(DesiredMode))
                 {
                     m |= DesiredMode;
                     ConsoleControl.SetMode(handle, m);