feat: query loading bars #22298
Merged
feat: query loading bars #22298
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
May 15, 2024 22:40
…thog into hackathon_query_loading_bars
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
added 4 commits
May 15, 2024 23:14
…thog into hackathon_query_loading_bars
|
Size Change: +97 B (+0.01%) Total Size: 1.05 MB ℹ️ View Unchanged
|
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
📸 UI snapshots have been updated2 snapshot changes in total. 0 added, 2 modified, 0 deleted:
Triggered by this commit. |
Suspect IssuesThis pull request was deployed and Sentry observed the following issues:
Did you find this useful? React with a 👍 or 👎 |
thmsobrmlr
pushed a commit
that referenced
this pull request
May 21, 2024
* printing results * sleep each row * in progress * returning loading status for single queries * cluster all * new schema * working row counts * change types and store in redis * loading * working redis * include and exclude * object creation * nan * Move some things around * WIP: loading bar * WIP: loading bar * summary * add better formatting * hooked up * add feature flag * fix numbers * fix nan * multiple queries * gate backend * remove sleep and print * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (1) * python typing * dom props * Update UI snapshots for `chromium` (1) * validate * fix test * bunch of bugfixes * Update UI snapshots for `chromium` (1) * Update UI snapshots for `chromium` (1) * backend test * remove stories * fix type issues * Update UI snapshots for `chromium` (2) --------- Co-authored-by: Alexander Spicer <aspicer@surfer-172-30-3-221-hotspot.internet-for-guests.com> Co-authored-by: timgl <tim@posthog.com> Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Long running queries confuse users and they don't what's going on. The hedgehog running with no feedback gets frustrating.
Changes
Roll out a beta of a loading bar behind a feature flag
Screen.Recording.2024-05-15.at.7.47.47.PM.mov
How did you test this code?
Loading paths tested on local