Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(data-warehouse): Postgres source quality of life improvements #21942

Merged
merged 3 commits into from Apr 30, 2024

Conversation

Gilbert09
Copy link
Contributor

Changes

  • Updated the source wizard form UI to take into account placeholders and field types (e.g. actually show a password input for the postgres password field)
  • Added an enable/disable all button when picking schemas
  • Added better error messages for connecting to your postgres instance (a failed connection would silently fail previously)
    • Also, fail the connection if the given schema doesn't exist
Screen.Recording.2024-04-29.at.15.36.49.mov
image

Does this work well for both Cloud and self-hosted?

  • Yes

How did you test this code?

  • Browser

@Gilbert09 Gilbert09 requested a review from EDsCODE April 29, 2024 14:38
Copy link
Contributor

Size Change: 0 B

Total Size: 1.04 MB

ℹ️ View Unchanged
Filename Size
frontend/dist/toolbar.js 1.04 MB

compressed-size-action

@Gilbert09 Gilbert09 merged commit bd8bd97 into master Apr 30, 2024
104 checks passed
@Gilbert09 Gilbert09 deleted the tom/postgres-qol-1 branch April 30, 2024 09:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants