Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(insights): Use lru_cache to reduce queries to instance settings #21938

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from

Conversation

webjunkie
Copy link
Contributor

@webjunkie webjunkie commented Apr 29, 2024

Problem

Lots of queries to instance settings

Screenshot 2024-04-29 at 14 32 15

Changes

👉 Stay up-to-date with PostHog coding conventions for a smoother review.

Does this work well for both Cloud and self-hosted?

How did you test this code?

Copy link

sentry-io bot commented Apr 29, 2024

🔍 Existing Issues For Review

Your pull request is modifying functions with the following pre-existing issues:

📄 File: posthog/models/instance_setting.py

Function Unhandled Issue
value JSONDecodeError: Expecting value: line 1 column 1 (char 0) /admin/posthog/instan...
Event Count: 1

Did you find this useful? React with a 👍 or 👎

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

@posthog-bot
Copy link
Contributor

This PR hasn't seen activity in a week! Should it be merged, closed, or further worked on? If you want to keep it open, post a comment or remove the stale label – otherwise this will be closed in another week.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants