fix: delete proxy records immediately if in the waiting or erroring s…

…tates (#22325)

* delete proxy records immediately if in the waiting or erroring states

* show "Live" instead of "Valid" as final status

* Update UI snapshots for `chromium` (1)

* fix syntax

* Update UI snapshots for `chromium` (1)

---------

Co-authored-by: github-actions <41898282+github-actions[bot]@users.noreply.github.com>

frontend/src/scenes/settings/project/Proxy.tsx

@@ -52,7 +52,7 @@ export function Proxy(): JSX.Element {
                         )}
                     >
                         {status === 'issuing' && <Spinner />}
-                        <span className="capitalize">{status}</span>
+                        <span className="capitalize">{status === 'valid' ? 'live' : status}</span>
                         {status === 'waiting' && (
                             <Tooltip title="Waiting for DNS records to be created">
                                 <IconInfo className="cursor-pointer" />

posthog/api/proxy_record.py

@@ -58,7 +58,9 @@ def destroy(self, request, *args, pk=None, **kwargs):
         queryset = self.organization.proxy_records.order_by("-created_at")
         record = queryset.get(id=pk)
 
-        if record:
+        if record and record.status in (ProxyRecord.Status.WAITING, ProxyRecord.Status.ERRORING):
+            record.delete()
+        elif record:
             record.status = ProxyRecord.Status.DELETING
             record.save()