Skip to content

Commit

Permalink
Fix taxonomicGroupTypes prop
Browse files Browse the repository at this point in the history
  • Loading branch information
webjunkie committed Apr 26, 2024
1 parent 515d6ff commit 40be2aa
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 12 deletions.
2 changes: 1 addition & 1 deletion frontend/src/scenes/dashboard/Dashboard.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -122,7 +122,7 @@ function DashboardScene(): JSX.Element {
dashboardFilters={dashboardFilters}
setDates={setDates}
setProperties={setProperties}
groupsTaxonomicTypes={[
taxonomicGroupTypes={[
TaxonomicFilterGroupType.EventProperties,
TaxonomicFilterGroupType.PersonProperties,
TaxonomicFilterGroupType.EventFeatureFlags,
Expand Down
14 changes: 3 additions & 11 deletions frontend/src/scenes/dashboard/DashboardEditBar.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ interface DashboardEditBarProps {
canEditDashboard: boolean
setDates: (dateFrom: string | null, dateTo: string | null) => void
setProperties: (properties: AnyPropertyFilter[]) => void
groupsTaxonomicTypes: TaxonomicFilterGroupType[]
taxonomicGroupTypes: TaxonomicFilterGroupType[]
onPendingChanges?: (stale: boolean) => void
}

Expand All @@ -25,7 +25,7 @@ export function DashboardEditBar({
canEditDashboard,
setDates,
setProperties,
groupsTaxonomicTypes,
taxonomicGroupTypes,
onPendingChanges,
}: DashboardEditBarProps): JSX.Element {
const [editMode, setEditMode] = useState(false)
Expand Down Expand Up @@ -93,15 +93,7 @@ export function DashboardEditBar({
onChange={setTempProperties}
pageKey={'dashboard_' + dashboard?.id}
propertyFilters={tempProperties}
taxonomicGroupTypes={[
TaxonomicFilterGroupType.EventProperties,
TaxonomicFilterGroupType.PersonProperties,
TaxonomicFilterGroupType.EventFeatureFlags,
...groupsTaxonomicTypes,
TaxonomicFilterGroupType.Cohorts,
TaxonomicFilterGroupType.Elements,
TaxonomicFilterGroupType.HogQLExpression,
]}
taxonomicGroupTypes={taxonomicGroupTypes}
/>
{canEditDashboard && !editMode ? (
<LemonButton type="secondary" size="small" onClick={() => setEditMode(true)}>
Expand Down

0 comments on commit 40be2aa

Please sign in to comment.