Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Trends docs refresh #8420

Merged
merged 18 commits into from
May 21, 2024
Merged

Trends docs refresh #8420

merged 18 commits into from
May 21, 2024

Conversation

andyvan-ph
Copy link
Contributor

@andyvan-ph andyvan-ph commented May 7, 2024 •
edited

Changes

  • Splits overlong trends docs into separate paginated pages for specific features
  • Updates lots of out of date bits + add some undocumented features

Checklist

  • Words are spelled using American English
  • Titles are in sentence case
  • Feature names are in sentence case too
  • Use relative URLs for internal links
  • If I moved a page, I added a redirect in vercel.json
  • Remove this template if you're not going to fill it out!

@andyvan-ph andyvan-ph added the docs Improvements or additions to product documentation, "Docs" label May 7, 2024
@vercel Vercel
Copy link

vercel bot commented May 7, 2024 •
edited

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
posthog ✅ Ready (Inspect) Visit Preview May 20, 2024 9:12am

@andyvan-ph
Copy link
Contributor Author

andyvan-ph commented May 7, 2024 •
edited

For some reason the /charts page 404s on my local build, which I assume why the Vercel build keeps failing. Not sure what's up with that.

@andyvan-ph andyvan-ph changed the title WIP: Trends docs refresh Trends docs refresh May 15, 2024
@andyvan-ph andyvan-ph requested a review from ivanagas May 15, 2024 16:57
ivanagas
ivanagas approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@ivanagas ivanagas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, I think it needs some internal links and fixing up the index page, but other than that ready to go :)

contents/docs/product-analytics/trends/aggregations.mdx Outdated Show resolved Hide resolved
contents/docs/product-analytics/trends/aggregations.mdx Outdated Show resolved Hide resolved
contents/docs/product-analytics/trends/aggregations.mdx Outdated Show resolved Hide resolved
contents/docs/product-analytics/trends/aggregations.mdx Outdated Show resolved Hide resolved
contents/docs/product-analytics/trends/breakdowns.mdx Outdated Show resolved Hide resolved
contents/docs/product-analytics/trends/tips.mdx Outdated Show resolved Hide resolved
contents/docs/product-analytics/trends/tips.mdx Outdated Show resolved Hide resolved
contents/docs/product-analytics/trends/tips.mdx Outdated Show resolved Hide resolved
contents/docs/product-analytics/trends/tips.mdx Outdated Show resolved Hide resolved
contents/docs/product-analytics/trends/tips.mdx Outdated Show resolved Hide resolved
@andyvan-ph @ivanagas
Ian's suggestions
04bc8d4 
Co-authored-by: Ian Vanagas <34755028+ivanagas@users.noreply.github.com>
@andyvan-ph
Copy link
Contributor Author

@ivanagas RE: index page, I tried doing what you suggested the other day and it broke the sidebar. I probably did it wrong, but going to leave as is since it's working.

@andyvan-ph andyvan-ph merged commit c83cdaa into master May 21, 2024
3 checks passed
@andyvan-ph andyvan-ph deleted the trends-docs-overhaul branch May 21, 2024 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ivanagas ivanagas ivanagas approved these changes

Assignees
No one assigned
Labels
docs Improvements or additions to product documentation, "Docs"
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@andyvan-ph @ivanagas