Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: replace rn sample #168

Merged
merged 4 commits into from
Jan 29, 2024
Merged

chore: replace rn sample #168

merged 4 commits into from
Jan 29, 2024

Conversation

marandaneto
Copy link
Member

@marandaneto marandaneto commented Jan 26, 2024

Problem

New project but ran into 2 issues
wix/react-native-navigation#7833
wix/react-native-navigation#7819

projects cannot be named with - anymore hence the _ naming.
the acronym rn is more popular than the longer version react_native.

#skip-changelog

Changes

Release info Sub-libraries affected

Bump level

  • Major
  • Minor
  • Patch

Libraries affected

  • All of them
  • posthog-web
  • posthog-node
  • posthog-react-native

Changelog notes

  • Added support for X

@marandaneto marandaneto requested review from benjackwhite and a team January 26, 2024 14:02
@marandaneto
Copy link
Member Author

@benjackwhite deleting everything and creating again was the solution and still, 2 issues that took a bit of time to figure out :D

@marandaneto marandaneto changed the title chore: replace sample chore: replace rn sample Jan 26, 2024
Copy link
Collaborator

@benjackwhite benjackwhite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Zero-read review - just assuming this is fine ;)

@pauldambra
Copy link
Member

98 files changed on a friday

Zero-read review - just assuming this is fine ;)

🤣

@marandaneto marandaneto marked this pull request as ready for review January 26, 2024 17:20
@marandaneto marandaneto merged commit 3a7787f into main Jan 29, 2024
3 checks passed
@marandaneto marandaneto deleted the chore/new-rn-sample branch January 29, 2024 09:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants