Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(hashicorp-vault-signing-manager): add 30 second timeout for vault #48

Merged
merged 1 commit into from
May 2, 2024
Merged

feat(hashicorp-vault-signing-manager): add 30 second timeout for vault #48

merged 1 commit into from
May 2, 2024

Conversation

polymath-eric
Copy link
Collaborator

Description

Add 30 second timeout for vault signing manager

Breaking Changes

JIRA Link

DA-1030

Checklist

  • Updated the Readme.md (if required) ?

Base automatically changed from ignore-non-ed25519 to main April 16, 2024 19:25
@polymath-eric polymath-eric force-pushed the add-timeout branch 2 times, most recently from a397adf to e172e18 Compare April 16, 2024 19:26
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Apr 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@polymath-eric polymath-eric merged commit 82f02a1 into main May 2, 2024
4 checks passed
@polymath-eric polymath-eric deleted the add-timeout branch May 2, 2024 13:37
@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version @polymeshassociation/hashicorp-vault-signing-manager@3.3.0 🎉

The release is available on:

@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version @polymeshassociation/signing-manager-types@3.3.0 🎉

The release is available on:

@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version @polymeshassociation/browser-extension-signing-manager@2.3.0 🎉

The release is available on:

@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version @polymeshassociation/fireblocks-signing-manager@2.5.0 🎉

The release is available on:

@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version @polymeshassociation/approval-signing-manager@3.3.0 🎉

The release is available on:

@prashantasdeveloper
Copy link
Collaborator

🎉 This PR is included in version @polymeshassociation/local-signing-manager@3.3.0 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@VictorVicente VictorVicente VictorVicente approved these changes

@prashantasdeveloper prashantasdeveloper prashantasdeveloper approved these changes

@sansan sansan Awaiting requested review from sansan sansan is a code owner

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@polymath-eric @prashantasdeveloper @VictorVicente