Add salted version of sampler functions in EXPRESSION samplers #455
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request
A slightly less naïve implementation of #371. Every sampler specified in an
EXPRESSION
sampler generates two functions:sampler(Point)
andsamplerSalted(Point, double)
. The salted version requires an additional, mandatory argument for salt, per Astrash's recommendation.May require a documentation change to record the existence of this feature and to warn against duplication of function names. Though highly unlikely, this change breaks config packs that result in name duplication.
The previous PR was closed so that the git history can be made cleaner without the need for revert commits.
Again open for any feedback at all.
Closes #371.
Changelog
EXPRESSION
s.Checklist
Mandatory checks
ver/
prefix)or is a branch that is intended to be merged into a version branch.
CONTRIBUTING.md
document in the root of the git repository.
Types of changes
Compatibility
Documentation
Testing
Licensing
release it under GPLv3.
released under GPLv3 or a compatible license.