Replace QT's JSON library with nlohmann's JSON library #1562
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: sightem <sightem@national.shitposting.agency>
Signed-off-by: sightem <sightem@national.shitposting.agency>
ghost
reviewed
Feb 26, 2023
ghost
reviewed
Feb 26, 2023
Signed-off-by: sightem <sightem@national.shitposting.agency>
|
You should not keep unused code commented. Makes the code harder to read and it's no longer needed. Just delete it. |
They're temporary, nvim's git integration plugin sucks and sometimes breaks when I wanna view the changes, they will be removed once I finish thoroughly testing the changes |
Signed-off-by: sightem <sightem@national.shitposting.agency>
Signed-off-by: sightem <sightem@national.shitposting.agency>
Signed-off-by: sightem <sightem@national.shitposting.agency>
Signed-off-by: sightem <sightem@national.shitposting.agency>
Signed-off-by: sightem <sightem@national.shitposting.agency>
Signed-off-by: sightem <sightem@national.shitposting.agency>
Currently not compilable Signed-off-by: sightem <sightem@national.shitposting.agency>
Signed-off-by: sightem <sightem@national.shitposting.agency>
Signed-off-by: sightem <sightem@national.shitposting.agency>
- Switched to .get<std::string>.c_str() instead of fromStdString() as it proved to be drastically faster at scale. - Improved some inconsistencies I came across. Signed-off-by: sightem <sightem@national.shitposting.agency>
Signed-off-by: sightem <sightem@national.shitposting.agency>
Signed-off-by: sightem <sightem@national.shitposting.agency>
Signed-off-by: sightem <sightem@national.shitposting.agency>
Signed-off-by: sightem <sightem@national.shitposting.agency>
currently compilable Signed-off-by: sightem <sightem@national.shitposting.agency>
- also fixed mod downloader Signed-off-by: sightem <sightem@national.shitposting.agency>
Signed-off-by: sightem <sightem@national.shitposting.agency>
Signed-off-by: sightem <sightem@national.shitposting.agency>
Signed-off-by: sightem <sightem@national.shitposting.agency>
Signed-off-by: sightem <sightem@national.shitposting.agency>
Signed-off-by: sightem <sightem@national.shitposting.agency>
Signed-off-by: sightem <sightem@national.shitposting.agency>
Signed-off-by: sightem <sightem@national.shitposting.agency>
- I did some small refactors also Signed-off-by: sightem <sightem@national.shitposting.agency>
Signed-off-by: sightem <sightem@national.shitposting.agency>
Signed-off-by: sightem <sightem@national.shitposting.agency>
i hate mac Signed-off-by: sightem <sightem@national.shitposting.agency>
Signed-off-by: sightem <sightem@national.shitposting.agency>
Signed-off-by: sightem <sightem@national.shitposting.agency>
Seems quite intuitive to me. You just insert stuff. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request replaces the usage of QT's JSON library with nlohmann's JSON library in order to improve code readability and maintainability. QT's JSON library syntax can be unintuitive and make code difficult to understand, whereas nlohmann's JSON library provides a more straightforward and easy-to-use syntax