Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UI/UX tweaks and quality of life #1103

Draft
wants to merge 18 commits into
base: develop
Choose a base branch
from
Draft

Conversation

ZekeZDev
Copy link
Contributor

@ZekeZDev ZekeZDev commented Sep 3, 2022

This has turned into quite a large amount of tweaks I have removed and added some new functionality and tweaked some existing functionality. The major noticeable changes are:

  • Redundant titles removed
    Before:
    image
    After:
    image
    This affects all pages including, settings, instance settings, instance creation, mod downloader.

  • Also pictured above are search filters to be consistent now have placeholder text instead of filter: [search] it is now [Search and filter...]

  • Rolypoly icon addded to icon selection
    image

  • Default instance icon is now the launcher logo

  • Vanilla renamed to Custom, icon changed to launcher logo and tab background removed

  • "Import from zip" renamed to "Import file"

  • Profiles renamed to Accounts to keep consistency with other references

  • install mods in version page removed

I, Ezekiel Smith <ezekielsmith@protonmail.com>, hereby add my Signed-off-by to this commit: 40531b3
I, Ezekiel Smith <ezekielsmith@protonmail.com>, hereby add my Signed-off-by to this commit: 664bccd
I, Ezekiel Smith <ezekielsmith@protonmail.com>, hereby add my Signed-off-by to this commit: 1edabd0
I, Ezekiel Smith <ezekielsmith@protonmail.com>, hereby add my Signed-off-by to this commit: 26eba7d
I, Ezekiel Smith <ezekielsmith@protonmail.com>, hereby add my Signed-off-by to this commit: a8b32c6
I, Ezekiel Smith <ezekielsmith@protonmail.com>, hereby add my Signed-off-by to this commit: 4522a5b
I, Ezekiel Smith <ezekielsmith@protonmail.com>, hereby add my Signed-off-by to this commit: 90b8ada
I, Ezekiel Smith <ezekielsmith@protonmail.com>, hereby add my Signed-off-by to this commit: 13f5a3c
I, Ezekiel Smith <ezekielsmith@protonmail.com>, hereby add my Signed-off-by to this commit: 5d8f83f
I, Ezekiel Smith <ezekielsmith@protonmail.com>, hereby add my Signed-off-by to this commit: 02912e7
I, Ezekiel Smith <ezekielsmith@protonmail.com>, hereby add my Signed-off-by to this commit: 9f11ce5
I, Ezekiel Smith <ezekielsmith@protonmail.com>, hereby add my Signed-off-by to this commit: e075850

Signed-off-by: Ezekiel Smith <ezekielsmith@protonmail.com>
Signed-off-by: Ezekiel Smith <ezekielsmith@protonmail.com>
@DioEgizio
Copy link
Contributor

image

image

there should be some spacing there imo

@DioEgizio
Copy link
Contributor

not correctly alligned

not correctly alligned

also it's not correctly alligned which is triggering me

@TayouVR
Copy link
Contributor

TayouVR commented Sep 3, 2022

tested it out too and I do agree, there needs to be a top (and right) margin
image

even with the built in fusion-dark it looks a bit too tightly packed for my taste
image

for comparison this is a system window in windows. matching the margin on all sides would be good i think. (should line up with bottom right buttons, etc.)
image

@HyperSoop
Copy link

For me, it crashes almost every time the game is closed, but is fine otherwise. Win64 legacy portable.

I, Ezekiel Smith <ezekielsmith@protonmail.com>, hereby add my Signed-off-by to this commit: 930b0cc
I, Ezekiel Smith <ezekielsmith@protonmail.com>, hereby add my Signed-off-by to this commit: 62a42de

Signed-off-by: Ezekiel Smith <ezekielsmith@protonmail.com>
Signed-off-by: Ezekiel Smith <ezekielsmith@protonmail.com>
@DioEgizio
Copy link
Contributor

image

still doesn't seem to have the margins at the top for me

@ZekeZDev
Copy link
Contributor Author

ZekeZDev commented Sep 4, 2022

Thats weird

@ZekeZDev
Copy link
Contributor Author

ZekeZDev commented Sep 4, 2022

image
this is what it looks like on windows

@Scrumplex Scrumplex added the enhancement New feature or request label Sep 5, 2022
@Scrumplex Scrumplex added this to the 5.0 milestone Sep 5, 2022
@DioEgizio
Copy link
Contributor

this closes #1078, so feel free to add "closes #1078" in the pr description

@ZekeZDev ZekeZDev added the blocked We need to wait for something else first label Sep 9, 2022
@ZekeZDev
Copy link
Contributor Author

ZekeZDev commented Sep 9, 2022

Need a solution for macos issues I also dont have a mac device for testing. If anyone would like to help contribute by testing mac for me that would be greatly appreciated.

@TayouVR
Copy link
Contributor

TayouVR commented Sep 9, 2022

wasn't there the idea to add the top margin as a empty extra widget with fixed height?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked We need to wait for something else first enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants