Changed the required doctrine/common #11
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Testing this now. Not sure why a max doctrine/common version is even being specified.
|
So testing didn't work as expected (as to the composer.json). I am testing this version of PSSDoctrineExtensionsBundle with the version of Doctrine/Common that's coming with sf2.1.x. |
|
The doctrine/common max version is specified to prevent any future BC breaks in doctrine causing compatibility problems. At the point the composer file was created doctrine had not yet released 2.3. If you have tested the bundle is working as expected with 2.3 then upping the compatible version as you have done in your PR is definitely the way to go. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Testing this now. Not sure why a max doctrine/common version is even being specified.