Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: checkbox input #70

Merged
merged 4 commits into from May 7, 2024
Merged

feat: checkbox input #70

merged 4 commits into from May 7, 2024

Conversation

joshuagraber
Copy link
Collaborator

Resolves #62

To test

  1. Run npm run dev
  2. Ensure that the test form works properly with the checkbox and it's styled appropriately

@joshuagraber joshuagraber self-assigned this May 6, 2024
vikramrojo
vikramrojo reviewed May 6, 2024
View reviewed changes
Copy link

@vikramrojo vikramrojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Took a look and have some feedback:

  • I think the cursor should change to interactive click
  • Possibly the click target should be larger

@joshuagraber
Copy link
Collaborator Author

Possibly the click target should be larger

@vikramrojo Can you say more about this? The checkbox and its label are clickable. What part are you wanting to be larger?

@vikramrojo
Copy link

@joshuagraber maybe it was just the missing cursor, but I couldn't make out what the target area was. It looks good now.

@vikramrojo vikramrojo self-requested a review May 6, 2024 22:37
vikramrojo
vikramrojo approved these changes May 6, 2024
View reviewed changes
Copy link

@vikramrojo vikramrojo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Design wise it looks good.

@joshuagraber joshuagraber merged commit 621064b into beta May 7, 2024
5 checks passed
@joshuagraber joshuagraber deleted the feat/checkbox-input branch May 7, 2024 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vikramrojo vikramrojo vikramrojo approved these changes

@josh-chamberlain josh-chamberlain Awaiting requested review from josh-chamberlain

Assignees

@joshuagraber joshuagraber

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshuagraber @vikramrojo