feat(router): add logic to router to handle meta tags #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshuagraber
commented
Mar 14, 2024
Comment on lines
+18
to
+19
| // Use meta property on route to override meta tag defaults | ||
| // meta: { title: 'Police Data Accessibility Project - Search', metaTags: [{ property: 'og:title', title: 'Police Data Accessibility Project - Search' }] }, |
There was a problem hiding this comment.
Hey @josh-chamberlain just wanted to call your attention to this. We can override any meta tag by route (in absence of specific route data, we fall back to the defaults). So if there are any of them that should have specific values, let me know and I can add those here as well.
Add support for multiple matched routes
|
@joshuagraber thanks! I'm good to merge this into |
|
Sounds good @josh-chamberlain changed the base branch, just need another ✅ to merge. |
mbodeantor
approved these changes
Mar 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Will handle #199 when merged.
To test
Run the app, visit several different routes, ensure that the tags change as expected per route (only the
og:urltag will change for now, but we can use themetaproperty on the routes object to update others if need be)