Update test_install.R - fix zenodo_record files listing #50
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you so much for the suggested solution, and my apologies I did not realize your work and help in time. I implemented the identical solution - seeing your suggestion early on would have saved me a lot of time. Please note that I reverted to relying on zen4R in my cwbtools package. Thanks a lot for your work! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to eblondel/zen4R#123
It seems zen4R is not invoked anymore in the cwbtools features but it's used in the test_install.R integration test. The
ZenodoRecordmodel for listing files had to be slightly adapted to align on the Zenodo API records endpoint.This PR is made jointly to fix your tests as warned by CRAN team with the attempt to publish zen4R 0.9