Cache location area encounters #12
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NamedAPIResource's load() does this for us. We can trust it. This is step one to extending it
This separate __is_loaded from __init__ which will eventually allow inheriting classes to override __init__ without worrying about name-mangling
This moves the final name-mangling outside of __init__ so that inheritance is truly possible
In addition to creating the resource, the biggest architecture change is making lookup_data accept a url separate from the subdir structure. This seemed less confusing than creating numerical directories in the pokemon cache, instead keeping them all inside the encounters subdir
|
Hmmm, apparently I removed some cachedir-creating code. Looking into it. |
|
Thank you for your contribution @jrubinator, and your patients (sorry for the delay here). I'm currently making several big improvements under the hood of pokebase. Unfortunately this means the changes you suggested no longer make sense with the current code state, so I have to close this PR. However, in the coming commits I intend to add support for subresources from the API, so keep your eye out for those (I had no idea subresources were even a thing, thanks for calling that to my attention). |
|
@GregHilmes - no problem! I look forward to seeing the enhancements :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This caches location area encounters, per issue #10
There's some logic in here to make sure that PokeAPI/pokeapi#335 doesn't have any impact here.