Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ✨ Add pokemon cries #1030

Merged
merged 3 commits into from Feb 7, 2024
Merged

Conversation

FallenDeity
Copy link
Contributor

Add pokemon cries resource field to pokemon endpoint

This is the first pr open for review regarding adding of pokemon cries resource to the api based on #982 and #242

It introduces the field cries to the /pokemon endpoint

"cries": {
    "latest":"https://raw.githubusercontent.com/PokeAPI/cries/main/cries/pokemon/latest/1.ogg",
    "legacy":"https://raw.githubusercontent.com/PokeAPI/cries/main/cries/pokemon/legacy/1.ogg"
}
  • latest is the most recent cry of the pokemon and being used in current gen games (source: showdown)
  • legacy is the old pokemon cries that were used in roms upto gen5 (source: veekun)

The cries are stored here here

Tests for the above addition can be found here

# cries params
self.assertEqual(
    cries_data["latest"],
    "{}".format(cries_data["latest"]),
)
self.assertEqual(
    cries_data["legacy"],
     "{}".format(cries_data["legacy"]),
)

Add pokemon cries resource field to pokemon endpoint
@FallenDeity
Copy link
Contributor Author

@Naramsim take a look where you're free and let me know if any changes are needed 😄

@Naramsim Naramsim changed the base branch from master to staging February 7, 2024 12:37
@Naramsim Naramsim changed the base branch from staging to master February 7, 2024 12:37
@Naramsim Naramsim merged commit 58b9590 into PokeAPI:master Feb 7, 2024
3 checks passed
@Naramsim
Copy link
Member

Naramsim commented Feb 7, 2024

Thanks @FallenDeity !!

@pokeapi-machine-user
Copy link

A PokeAPI/api-data refresh has started. In ~45 minutes the staging branch of PokeAPI/api-data will be pushed with the new generated data.

The staging branch will be deployed in our staging environment and the entire API will be ready to review.

A Pull Request (master<-staging) will be also created at PokeAPI/api-data and assigned to the PokeAPI Core team to be reviewed. If approved and merged new data will soon be available worldwide at pokeapi.co.

@pokeapi-machine-user
Copy link

The updater script has finished its job and has now opened a Pull Request towards PokeAPI/api-data with the updated data.

The Pull Request can be seen deployed in our staging environment when CircleCI deploy will be finished (check the start time of the last build).

Naramsim pushed a commit to PokeAPI/api-data that referenced this pull request Feb 7, 2024
@FallenDeity FallenDeity deleted the add-pokemon-cries branch February 11, 2024 22:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants