Add PHPStan analysis to PRs and mainline pushes #710
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coldacid
force-pushed
the
phpstan
branch
2 times, most recently
from
13df74c
to
50ad1bd
Compare
added 8 commits
November 3, 2022 07:26
Add sanderronde.phpstan-vscode to the suggested extensions list, and provide config settings for the extension as well.
Add a couple of ignore rules so that we are not spammed with mentions of $config across the project, or undefined variable errors for any theme file. We know that these variables are in fact defined, even if phpstan can't figure it out.
We're also renaming the CI workflows file from "Unit Tests" as we now do more than just run PHPUnit in it.
recca0120.vscode-phpunit isn't maintained anymore, switch to renandelmonico.vscode-php-test-explorer instead.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Further improve testing and analysis during development.