Check, LiveData extended

Pluu · Oct 15, 2023 · 9733952 · 9733952
1 parent b8c4f2f
commit 9733952
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 1 deletion.
diff --git a/lint/src/main/java/com/pluu/lint/LiveDataObserveNotNullDetector.kt b/lint/src/main/java/com/pluu/lint/LiveDataObserveNotNullDetector.kt
@@ -10,6 +10,7 @@ import com.android.tools.lint.detector.api.Scope
 import com.android.tools.lint.detector.api.Severity
 import com.android.tools.lint.detector.api.SourceCodeScanner
 import com.android.tools.lint.detector.api.isKotlin
+import com.intellij.psi.PsiClassType
 import com.intellij.psi.PsiMethod
 import org.jetbrains.kotlin.utils.addToStdlib.firstIsInstanceOrNull
 import org.jetbrains.uast.UCallExpression
@@ -25,6 +26,8 @@ class LiveDataObserveNotNullDetector : Detector(), SourceCodeScanner {
     override fun visitMethodCall(context: JavaContext, node: UCallExpression, method: PsiMethod) {
         super.visitMethodCall(context, node, method)
         if (!isKotlin(context.psiFile)) return
+        if (!isLiveDataReceiver(context, node)) return
+
         val lambda = node.valueArguments.firstIsInstanceOrNull<ULambdaExpression>()
             ?.valueParameters ?: return
         if (lambda.size != 1) return
@@ -34,6 +37,15 @@ class LiveDataObserveNotNullDetector : Detector(), SourceCodeScanner {
         }
     }
 
+    private fun isLiveDataReceiver(context: JavaContext, node: UCallExpression): Boolean {
+        val psiClassType = (node.receiver?.getExpressionType() as? PsiClassType) ?: return false
+        return context.evaluator.extendsClass(
+            psiClassType.rawType().resolve(),
+            "androidx.lifecycle.LiveData",
+            false
+        )
+    }
+
     private fun report(context: JavaContext, node: UCallExpression) {
         // Lint 7.0 이상부터 사용
         val incident = Incident(context, ISSUE)

diff --git a/lint/src/test/java/com/pluu/lint/LiveDataObserveNotNullDetectorTest.kt b/lint/src/test/java/com/pluu/lint/LiveDataObserveNotNullDetectorTest.kt
@@ -22,7 +22,7 @@ import com.pluu.lintstudy.BaseActivity
 import com.pluu.lintstudy.utils.observeNotNull
 
 class SampleActivity : BaseActivity() {
-    private val stringLiveData: LiveData<String> = MutableLiveData<String>()
+    private val stringLiveData: LiveData<String?> = MutableLiveData<String?>()
     private val stringNullableLiveData: LiveData<String?> = MutableLiveData<String?>()
     private val unitLiveData: LiveData<Unit> = MutableLiveData<Unit>()