Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added CPU temperature information #44

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

whitfijs-jw
Copy link

- added retrieval of CPU temperature 'x86_pkg_temp' from /sys/class/thermal/ directory -- this 'should' be the highest coretemp read from hwmon
- copy pasta for the indicator and info in the drop down view
- added CPU temp to schema
- so far only tested on a Sandy Bride laptop -- can probably test on a Haswell and AMD FX in the near future

volumetrix and others added 3 commits December 17, 2019 17:54
	- added retrieval of CPU temperature 'x86_pkg_temp' from /sys/class/thermal/ directory -- this 'should' be the highest coretemp read from hwmon
	- copy pasta for the indicator and info in the drop down view
	- added CPU temp to schema
	- so far only tested on a Sandy Bride laptop -- can probably test on a Haswell and AMD FX in the near future
	- fixed issue with string compare on "x86_pkg_temp"
	- added try catch for enumerator to satify warnings
@whitfijs-jw
Copy link
Author

Should be cleaned up now. I liked the layout of the indicator so I figured I'd add CPU temp. x86_pkg_temp likely isn't going to work for all platforms -- it works on the 2 Intel CPUs computers that I have laying around. The pattern matching for the type in update_temperature in CPU.vala can be extended for other platforms. Thanks again for your work -- hope this helps someone.

@PlugaruT
Copy link
Owner

Thanks for your work. I will probably pull the branch and test is myself to see how it looks. Will come back with an update.

@umbynos
Copy link

umbynos commented Dec 26, 2019

Hello! Sorry to interrupt, I've tried to use it on my Dell laptop, I'm on latest version of Elementary, but no temperature is showing, I've tried watching in settings but did not found anything.. Am I missing some steps? I've followed the same install procedure in the Readme. Maybe I should remove the previous installation?

image

@whitfijs-jw
Copy link
Author

Sorry for the delay, the extension I added depends on finding the type "x86_pkg_temp" in "/sys/class/thermal/thermal_zone*" directory

You can list the types like this:
cat /sys/class/thermal/thermal_zone*/type

If "x86_pkg_temp" isn't a type there let me know and I can add more patterns to support different platforms.

@umbynos
Copy link

umbynos commented Apr 7, 2020

On a fresh install it works. Maybe the problem it's reinstalling on a machine with the plugin already installed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants