Autosaving and upgraded to .NET 8 #582

CPKreu · 2023-11-28T18:09:33Z

Added periodic autosaving and upgraded to .NET 8

TODO

Add periodic autosaving
Allow disabling autosaving for the current document session
Add icons to the UI
Tighter integration with crash system
Last command before crash log
Fix "Open from clipboard" causes a crash #581

…to a file

…sion

src/PixiEditor/Models/DataHolders/CrashReport.cs

src/PixiEditor/ViewModels/SubViewModels/Document/AutosaveDocumentViewModel.cs

flabbet · 2023-11-29T15:18:37Z

Also I'm thinking, why save every x setting is a dropdown not number input?

flabbet · 2023-11-29T15:29:44Z

Also seems like autosave timer isn't working?

flabbet

PixiEditor doesn't restore files that are manually saved after closing, while autosaved files are. I think this should work like VS Code, last session is restored no matter if it's unsaved by user or not.

flabbet

Autosave worked for me once and then stopped, no matter if I restarted the app or paused and resumed via AutosaveControl. Timer seems to be frozen

flabbet · 2023-12-03T16:43:22Z

Open PNG
Draw something on it
Close PixiEditor
Reopen PixiEditor, recovered png doesn't have a name

~~Also unsaved documents lose thier translated name, so instead of "Bez Nazwy" (pl) on recover it becomes "Unnamed"~~ nvm I'm dumb, I never had Polish set

…seems unnecessary as SendExceptionInfoToWebhook is already async, but imma assume it has a purpose)

Equbuxu

I found an infinite loop
triggered by transform selection, and close without applying
seems like it infinitely autosaves 
and it also seems like Document.UpdateableChangeActive isn't set properly for transforming selection 

Equbuxu — 今日 01:24
and now I can't repro it
also for some reason files that were saved right before closing are marked as unsaved after reopening
while Untitled files that were never saved are marked as saved
but only sometimes

also passthrough action and modified/deleted on disk labels are still todo

…te preferences

…r or important events

Equbuxu

CrashHelper.SendExceptionInfoToWebhook must not use Task.Run (or anything with a separate thread), supposedly the reason for adding it was this:

I remember it not sending the exception in certain scenerios cause it wasn't awaited
weird, it shouldn't matter whether you await it or not. I can only imagine it happening if the app shuts down before it has a chance to run
I think that was it

Also it seems like a good idea to go through the entire project and closely examite each Task.Run, they are dangerous

Equbuxu · 2024-02-04T19:50:24Z

src/PixiEditor/NotifyableObject.cs

+#if DEBUG
+        throw exception;
+#else
+        exception.GenerateStackTrace();


I'd crash here, as that's what WPF normally does when it detects a non-ui thread

Equbuxu · 2024-02-04T19:58:03Z

src/PixiEditor/ViewModels/SubViewModels/Main/DebugViewModel.cs

            "Cancel"
        };

        dialog.ShowDialog();
    }

+    [Command.Debug("PixiEditor.Debug.BackupUserPreferences", @"%appdata%\PixiEditor\user_preferences.json", "BACKUP_USR_PREFS", "BACKUP_USR_PREFS")]
+    [Command.Debug("PixiEditor.Debug.BackupEditorData", @"%localappdata%\PixiEditor\editor_data.json", "BACKUP_EDITOR_DATA", "BACKUP_EDITOR_DATA")]


this can break on ms store #495; use Environment.GetFolderPath(... instead

Equbuxu · 2024-02-04T19:58:14Z

src/PixiEditor/ViewModels/SubViewModels/Main/DebugViewModel.cs

+    }
+
+    [Command.Debug("PixiEditor.Debug.LoadUserPreferencesBackup", @"%appdata%\PixiEditor\user_preferences.json", "LOAD_USR_PREFS_BACKUP", "LOAD_USR_PREFS_BACKUP")]
+    [Command.Debug("PixiEditor.Debug.LoadEditorDataBackup", @"%localappdata%\PixiEditor\editor_data.json", "LOAD_EDITOR_DATA_BACKUP", "LOAD_EDITOR_DATA_BACKUP")]


this can break on ms store #495; use Environment.GetFolderPath(... instead

Equbuxu · 2024-02-04T20:06:02Z

src/PixiEditor/Models/DocumentModels/ActionAccumulator.cs

@@ -39,6 +39,7 @@ public void AddFinishedActions(params IAction[] actions)
        queuedActions.AddRange(actions);
        queuedActions.Add(new ChangeBoundary_Action());
        TryExecuteAccumulatedActions();
+        document.AutosaveViewModel.HintFinishedAction();


You can still pass ChangeBoundary_Action into AddActions manually, and it won't get picked up. Although it is a bit hard to account for

Actually, this also won't work because TryExecuteAccumulatedActions doesn't guarantee the actions will be executed right away, so HintFinishedActions can get called when in fact we are still mid-change

I decided that this doesn't really matter, saving during an updateable change shouldn't cause any issues apart from a potential lag spike, and this is fine for preventing the lag spike

Equbuxu · 2024-02-04T22:39:53Z

Looks like DocumentViewModel.MarkAsSaved(); should be called using a passthough action, otherwise there is a problem of "you've added some actions, marked document as saved, then actions get processed, last change guid changes, document is no longer considered saved". This is the cause of * indicator appearing on images you've just opened

Equbuxu · 2024-02-08T19:14:58Z

Strange inconsistency:

open an existing .pixi, draw a rectangle and close pixieditor without applying transform -> Pixieditor closes without saving the rectangle
create a new .pixi, draw a rectangle, close without applying -> Pixieditor asks if you want to save the document
and ofc if you do apply the change, pixieditor will just save properly without asking in both cases
what's described in 1 also happens to never-saved-by-user files restored from previous session

I have also noticed pixieditor hanging and getting into an infinite autosaving loop during 2, but not sure if it's specific to 2 (probably not) or just something that can randomly happen. Ironically it happens inside "SafeAutosave". Might be caused by the -1 from AutosavePeriodMinutes ending up in the timer, with that timer then being enabled in RestartTimers and immediately firing (?) when an autosave happens during close

Equbuxu · 2024-02-08T19:23:18Z

I just spent like 5 minutes trying to remember what the last checkbox does (wdym autosave if I already said I want to backup every 5 minutes? is it an unrelated feature? autosave when then?) so apparently this wording sucks. I think all three features should have labels that are a lot more descriptive

Equbuxu · 2024-02-08T19:35:06Z

Seems like autosave files never get deleted? I made some new documents, closed pixieditor, reopened it, then closed all documents without saving, closed pixieditor, and now I have zombie .pixi files laying in Temp\PixiEditor\Autosave

Equbuxu · 2024-02-08T19:37:40Z

set your settings to this:

create a new document and wait for it to get autosaved. Then close pixieditor. You don't get prompted about having unsaved stuff, but nothing is restored after you reopen pixieditor (no shit, restore opened files on startup is disabled). So effectively you'be just lost your document, unless you know you can look for it in the temp/pixieditor/autosave directory

Equbuxu · 2024-02-08T20:46:57Z

With backup timer running, quickly create a few documents and close them right away. Wait for the interval of the timer. Once it elapses, the closed documents write autosaves into autosave directory. They must be sticking around in memory because of avalondock
I want a seconds counter
Would be nice to handle the case where pixieditor is killed (without it crashing), backups aren't restored in this case even though nothing is stopping us from restoring them

…eally like how it turned out tho

CPKreu added 6 commits November 24, 2023 11:37

Upgraded to .NET 8.0

5239405

Implemented autosaving

4b96289

Put autosaves in extra temp directory

9e7911f

Added autosave period setting

f3fd30e

Implemented disabling autosave

2bf506a

Fixed wrong error being passed when PixiEditor has no right to write …

e19c7e5

…to a file

CPKreu added the enhancement New feature or request label Nov 28, 2023

CPKreu self-assigned this Nov 28, 2023

CPKreu added 9 commits November 29, 2023 00:24

Fixed crash report and integrated temp autosave files

f02f8a5

Made CodeFactor happy

1a41f55

Added autosave icons and ability to pause autosaving for document ses…

9095b14

…sion

Fixed #581 "Open from clipboard" causes a crash

a8710fe

Fixed textTimer being called before UpdateMainMenuTextSave being called

c4bc98f

Enhanced crash reports

16705ea

Made Codefactor happy again

2073f58

Removed settings button for now

7c8b750

Toggle between pause and play icon in autosave control

3e13ff3

CPKreu requested a review from flabbet November 29, 2023 14:28

flabbet requested changes Nov 29, 2023

View reviewed changes

CPKreu added 3 commits December 1, 2023 14:33

Added Paths.PathToUnsavedFilesFolder

5a02a7d

Use separate message when all changes are already saved

1afefa4

Autosave unsaved files on close

f1d4aac

CPKreu requested a review from flabbet December 1, 2023 14:51

flabbet requested changes Dec 1, 2023

View reviewed changes

CPKreu added 2 commits December 2, 2023 13:31

Save all files on close when autosaving is enabled

e049fab

Added lots of new report state info

653c0a9

Change palettes folder name back to Palettes

d4daa55

Equbuxu force-pushed the autosave branch from c71e2d1 to d4daa55 Compare December 12, 2023 20:47

Copy global-ish variable to avoid closing over it (tbh that task.run …

0fe207a

…seems unnecessary as SendExceptionInfoToWebhook is already async, but imma assume it has a purpose)

Equbuxu requested changes Dec 12, 2023

View reviewed changes

Equbuxu mentioned this pull request Dec 13, 2023

Fixes #590

Merged

flabbet added 4 commits January 13, 2024 10:38

Merge branch 'master' into autosave

2c2ee12

Merge fixes

e035514

Autosave all on crash

2141eba

Updated installer to install .NET 8

d138826

flabbet requested a review from Equbuxu January 13, 2024 11:09

CPKreu added 8 commits January 21, 2024 14:03

Don't autosave all files on crash

4fd89f8

Added preference constants attribute

3c62ff4

Fix AutosaveAllForNextSession writing UnsavedNextSessionFiles to remo…

e6739c5

…te preferences

Renamed RemotePreferenceConstant to to SyncedPreferenceConstant

78e2859

If we got the default value use the defaultValue

cb17bcc

Keep showing text as a text block instead of tooltip but only on hove…

559a8a7

…r or important events

Fixed CodeFactor

46fc262

Improved PreferencesDiagnostics

bf70dc8

Equbuxu requested changes Feb 4, 2024

View reviewed changes

Equbuxu reviewed Feb 4, 2024

View reviewed changes

Equbuxu and others added 4 commits February 11, 2024 23:17

Make 'Mark as saved' a passthrough action, now the * works correctly

b9dddac

Separated out autosave control updates from autosave logic, I don't r…

fb28d43

…eally like how it turned out tho

Autosave progress

a66cf20

FIxed compilation errors

1970872

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Autosaving and upgraded to .NET 8 #582

Autosaving and upgraded to .NET 8 #582

CPKreu commented Nov 28, 2023 •

edited

flabbet commented Nov 29, 2023

flabbet commented Nov 29, 2023

flabbet left a comment

flabbet left a comment •

edited

flabbet commented Dec 3, 2023 •

edited

Equbuxu left a comment

Equbuxu left a comment

Equbuxu Feb 4, 2024

Equbuxu Feb 4, 2024

Equbuxu Feb 4, 2024

Equbuxu Feb 4, 2024 •

edited

Equbuxu Feb 17, 2024

Equbuxu commented Feb 4, 2024

Equbuxu commented Feb 8, 2024

Equbuxu commented Feb 8, 2024 •

edited

Equbuxu commented Feb 8, 2024

Equbuxu commented Feb 8, 2024 •

edited

Equbuxu commented Feb 8, 2024

Autosaving and upgraded to .NET 8 #582

Are you sure you want to change the base?

Autosaving and upgraded to .NET 8 #582

Conversation

CPKreu commented Nov 28, 2023 • edited

flabbet commented Nov 29, 2023

flabbet commented Nov 29, 2023

flabbet left a comment

Choose a reason for hiding this comment

flabbet left a comment • edited

Choose a reason for hiding this comment

flabbet commented Dec 3, 2023 • edited

Equbuxu left a comment

Choose a reason for hiding this comment

Equbuxu left a comment

Choose a reason for hiding this comment

Equbuxu Feb 4, 2024

Choose a reason for hiding this comment

Equbuxu Feb 4, 2024

Choose a reason for hiding this comment

Equbuxu Feb 4, 2024

Choose a reason for hiding this comment

Equbuxu Feb 4, 2024 • edited

Choose a reason for hiding this comment

Equbuxu Feb 17, 2024

Choose a reason for hiding this comment

Equbuxu commented Feb 4, 2024

Equbuxu commented Feb 8, 2024

Equbuxu commented Feb 8, 2024 • edited

Equbuxu commented Feb 8, 2024

Equbuxu commented Feb 8, 2024 • edited

Equbuxu commented Feb 8, 2024

CPKreu commented Nov 28, 2023 •

edited

flabbet left a comment •

edited

flabbet commented Dec 3, 2023 •

edited

Equbuxu Feb 4, 2024 •

edited

Equbuxu commented Feb 8, 2024 •

edited

Equbuxu commented Feb 8, 2024 •

edited