Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added pixiIcon.png and added it to MSIX Package (also changed MSIX ve… #235

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

CPKreu
Copy link
Member

@CPKreu CPKreu commented Oct 15, 2021

Added a file icon for pixi files

@CPKreu
Copy link
Member Author

CPKreu commented Oct 15, 2021

InnoSetup does not use the new icon yet

@CPKreu CPKreu self-assigned this Oct 15, 2021
@codecov-commenter
Copy link

codecov-commenter commented Oct 15, 2021

Codecov Report

Merging #235 (5c9bbec) into master (fafb0f4) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #235   +/-   ##
=======================================
  Coverage   45.13%   45.13%           
=======================================
  Files         303      303           
  Lines       12124    12124           
  Branches     1225     1225           
=======================================
  Hits         5472     5472           
  Misses       6381     6381           
  Partials      271      271           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fafb0f4...5c9bbec. Read the comment docs.

@flabbet
Copy link
Member

flabbet commented Oct 15, 2021

Where is the icon xd?
image

@CPKreu
Copy link
Member Author

CPKreu commented Oct 15, 2021

I used git commit -a which didn't add the icon

I compressed it so much that you can't see it with the human eye

Copy link
Member

@flabbet flabbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

provide icon

Copy link
Member

@flabbet flabbet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Icon is good, but you must make ISS association, also change non-MSIX version to v0.1.7 too

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants