Fix some display crashes after resyncing skeletons. #1397
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
to remove skeletons that did not have any bindings to skinned prims. This could lead to crashes later on from accessing expired prims. UsdSkelImagingSkeletonAdapter::_RemovePrim() checks _skelBindingMap to determine whether the provided path is the skeleton prim. This was inconsistent with UsdSkelImagingSkeletonAdapter::ProcessPrimResync(), which checks _skelDataCache via _GetSkelData(). If there aren't any bindings, the skeleton is in _skelDataCache but not _skelBindingMap. Fixes: PixarAnimationStudios#1228, PixarAnimationStudios#1248
|
Filed as internal issue #USD-6489 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Change(s)
This fixes an issue where
UsdSkelImagingSkeletonAdapter::_RemovePrim()failed to remove skeletons that did not have any bindings to skinned prims, which could lead to crashes later on from accessing expired prims.UsdSkelImagingSkeletonAdapter::_RemovePrim()checks_skelBindingMapto determine whether the provided path is the skeleton prim. This was inconsistent withUsdSkelImagingSkeletonAdapter::ProcessPrimResync(), which checks_skelDataCachevia_GetSkelData(). If there aren't any bindings, the skeleton is in_skelDataCachebut not_skelBindingMap.Fixes Issue(s)
Fixes: #1228, #1248